From d91653ed8467c81203a7cccb663b903c38d40720 Mon Sep 17 00:00:00 2001 From: Ethan Smith Date: Wed, 20 Oct 2021 05:24:12 -0700 Subject: [PATCH 1/4] Try running self check on PyPy in CI --- .github/workflows/test.yml | 5 +++++ tox.ini | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a8360ddd2703..a78c7008ce78 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -80,6 +80,11 @@ jobs: arch: x64 os: ubuntu-latest toxenv: type + - name: Type check our own code + python: 'pypy-3.8' + arch: x64 + os: ubuntu-latest + toxenv: type-pypy - name: Code style with flake8 python: '3.7' arch: x64 diff --git a/tox.ini b/tox.ini index ac7cdc72fdb7..f44b50dba089 100644 --- a/tox.ini +++ b/tox.ini @@ -53,6 +53,13 @@ commands = python -m mypy --config-file mypy_self_check.ini -p mypy -p mypyc python -m mypy --config-file mypy_self_check.ini misc/proper_plugin.py scripts/mypyc + +[testenv:type] +description = type check ourselves +basepython = pypy3 +commands = + python -m mypy --config-file mypy_self_check.ini -p mypy + [testenv:docs] description = invoke sphinx-build to build the HTML docs basepython = python3.7 From bc6e2ef77d13c369b78f33b32d7d07688bfcd0fe Mon Sep 17 00:00:00 2001 From: Ethan Smith Date: Wed, 20 Oct 2021 05:27:07 -0700 Subject: [PATCH 2/4] Fix name of tox env --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index f44b50dba089..60c4047b6737 100644 --- a/tox.ini +++ b/tox.ini @@ -54,7 +54,7 @@ commands = python -m mypy --config-file mypy_self_check.ini misc/proper_plugin.py scripts/mypyc -[testenv:type] +[testenv:type-pypy] description = type check ourselves basepython = pypy3 commands = From 3d195e47000352aa9b75e09a90b74e71b5c2250c Mon Sep 17 00:00:00 2001 From: Ethan Smith Date: Wed, 20 Oct 2021 05:29:29 -0700 Subject: [PATCH 3/4] Make name of Github Action step clearer --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a78c7008ce78..b80c297308fa 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -80,7 +80,7 @@ jobs: arch: x64 os: ubuntu-latest toxenv: type - - name: Type check our own code + - name: Type check our own code (with PyPy) python: 'pypy-3.8' arch: x64 os: ubuntu-latest From ba8e6eacad531583c0affc9ccde785cf22941daf Mon Sep 17 00:00:00 2001 From: Ethan Smith Date: Wed, 20 Oct 2021 05:31:01 -0700 Subject: [PATCH 4/4] Use more minimal deps --- tox.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/tox.ini b/tox.ini index 60c4047b6737..507636c12762 100644 --- a/tox.ini +++ b/tox.ini @@ -57,6 +57,7 @@ commands = [testenv:type-pypy] description = type check ourselves basepython = pypy3 +deps = -rmypy-requirements.txt commands = python -m mypy --config-file mypy_self_check.ini -p mypy