Bug: Duplicate Scheduled Year String Appearing For Single Day Events Whose Scheduled Year String Is Rendered

[alvindera97]

Describe the bug

What

For single day events (events that start and end on the same day) that require year string to be displayed [which are]:

• Single day events scheduled for a future year
• Single day events that have passed rendered at the "You just missed..." section of the main events page {pythondotorg url}/events/

The year string is rendered multiple times.

Here are a couple of examples

1. Past event scenario

2. Future event scenario

To Reproduce

• Set up a single day event scheduled to start in the future year or scheduled in the past (e.g. event has just been concluded)
• Navigate to the main events page (http://localhost:8000/events) and observe the year string rendered multiple times.

Expected behavior

• Single day events (regardless of schedule year) should only render a single year string (if necessary) since the event is guaranteed to start and end within the same year.

Addressing "If necessary"

• Future single day event scheduled within the current year does not need to render the current year as there is no date/year ambiguity.
• Past single day events (Events just missed) would need to render the year string dispelling any ambiguity on year event took place.

URL to the issue

No response

Screenshots

No response

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Other

Operating System

Linux

Browser Version

No response

Relevant log output

No response

Additional context

I've traced down the offending template logic:

pythondotorg/templates/events/includes/time_tag.html

Lines 1 to 9 in 1bfeace

	{% if next_time.single_day %}
	<time datetime="{{ next_time.dt_start|date:'c' }}">{{ next_time.dt_start|date:"d N" }}
	<span id="start-{{ object.id }}"{% if scheduled_start_this_year %} class="say-no-more"{% endif %}>
	{{ next_time.dt_start|date:"Y" }}
	</span>
	<span id="start-{{ object.id }}"{% if scheduled_end_this_year %} class="say-no-more"{% endif %}>
	{{ next_time.dt_start|date:"Y" }}
	</span>

[alvindera97]

#2627 should close this issue.