Fix unhandled promise rejection tracker, again

Delay checking for unhandled rejections so we can make sure to check
after other promise jobs have ran.

Author: saghul

quickjs.c

@@ -50221,6 +50221,9 @@ static JSValue promise_rejection_tracker_job(JSContext *ctx, int argc,
     JSRuntime *rt;
     JSPromiseData *s;
     JSValueConst promise;
+    struct list_head *el, *el1;
+    JSJobEntry *job;
+    bool has_other_jobs;
 
     assert(argc == 1);
 
@@ -50233,6 +50236,22 @@ static JSValue promise_rejection_tracker_job(JSContext *ctx, int argc,
 
     promise_trace(ctx, "promise_rejection_tracker_job\n");
 
+    // Push the rejection tracker jobs to the end of the queue if there are other jobs.
+    // This allows us to handle rejections that get added later and thus would handle the
+    // rejection _after_ we check for it.
+    has_other_jobs = false;
+    list_for_each_safe(el, el1, &rt->job_list) {
+        job = list_entry(el, JSJobEntry, link);
+        if (job->job_func != promise_rejection_tracker_job) {
+            has_other_jobs = true;
+            break;
+        }
+    }
+    if (has_other_jobs) {
+        JS_EnqueueJob(ctx, promise_rejection_tracker_job, 1, &promise);
+        return JS_UNDEFINED;
+    }
+
     // Check again in case the hook was removed.
     if (rt->host_promise_rejection_tracker)
         rt->host_promise_rejection_tracker(

tests/bug39.js renamed to tests/bug39/1.js

@@ -0,0 +1,6 @@
+/*---
+flags: [qjs:track-promise-rejections]
+---*/
+
+const error = await Promise.resolve().then(() => Promise.reject('reject')).catch(e => e)
+print('Got this error:', error)

tests/bug39/2.js

@@ -0,0 +1,7 @@
+/*---
+flags: [qjs:track-promise-rejections]
+---*/
+
+const promise = Promise.reject('reject')
+const error = await Promise.resolve().then(() => promise).catch(e => e)
+print('Got this error:', error)