Skip to content

Commit 46878e3

Browse files
authored
Do not build tokio-rustls in the CI for the time being (#14517)
A discrepancy between the `cmake` version available on the runners and the one required by the `aws-lc-sys` dependency prevents the crate from building. changelog: none r? @flip1995 cc @Alexendoo
2 parents 6ca6b09 + d81396b commit 46878e3

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

.github/workflows/lintcheck.yml

-8
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ jobs:
4949
path: target/debug/lintcheck
5050
key: lintcheck-bin-${{ hashfiles('lintcheck/**') }}
5151

52-
# Install cmake to build aws-lc-sys to build tokio-rustls
53-
- name: Install cmake
54-
run: sudo apt-get install -y cmake
55-
5652
- name: Build lintcheck
5753
if: steps.cache-lintcheck-bin.outputs.cache-hit != 'true'
5854
run: cargo build --manifest-path=lintcheck/Cargo.toml
@@ -96,10 +92,6 @@ jobs:
9692
path: target/debug/lintcheck
9793
key: lintcheck-bin-${{ hashfiles('lintcheck/**') }}
9894

99-
# Install cmake to build aws-lc-sys to build tokio-rustls
100-
- name: Install cmake
101-
run: sudo apt-get install -y cmake
102-
10395
- name: Build lintcheck
10496
if: steps.cache-lintcheck-bin.outputs.cache-hit != 'true'
10597
run: cargo build --manifest-path=lintcheck/Cargo.toml

lintcheck/ci_crates.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ winnow = { name = 'winnow', version = '0.6.13' }
122122
cpufeatures = { name = 'cpufeatures', version = '0.2.12' }
123123
nix = { name = 'nix', version = '0.29.0' }
124124
fnv = { name = 'fnv', version = '1.0.7' }
125-
tokio-rustls = { name = 'tokio-rustls', version = '0.26.0' }
125+
# As of 2025-04-01, one dependency doesn't build because of cmake version discrepancy
126+
# tokio-rustls = { name = 'tokio-rustls', version = '0.26.0' }
126127
iana-time-zone = { name = 'iana-time-zone', version = '0.1.60' }
127128
rustls-webpki = { name = 'rustls-webpki', version = '0.102.5' }
128129
crc32fast = { name = 'crc32fast', version = '1.4.2' }

0 commit comments

Comments
 (0)