Skip to content

compiletest: consider rejecting conditional test execution directives being used together with unconditional test disabling directives #139970

Open
@jieyouxu

Description

@jieyouxu

Remark: useless/misleading //@ run-pass in a few aux files that are //@ ignore-test (//@ ignore-auxiliary)

Originally posted by @jieyouxu in #139967 (comment)

Consider rejecting combination of

  • Conditional test execution directives (e.g. //@ ignore-*), with
  • Unconditional test execution directives (e.g. //@ ignore-test),

Since the unconditional test ignore will "absorb" conditional ones. Probably do this after reworking directive handling.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions