Implement #![debugger_visualizer]

[bjorn3]

https://doc.rust-lang.org/nightly/reference/attributes/debugger.html#using-debugger_visualizer-with-gdb
https://github.com/rust-lang/rust/blob/ab0f3e680e4fd50218914b8afa6900a67377721c/compiler/rustc_codegen_llvm/src/debuginfo/gdb.rs

The .debug_gdb_scripts section should contain \x01gdb_load_rust_pretty_printers.py followed by for each #![debugger_visualizer(gdb_script_file = "...")] the pretty printer inlined into the executable. Except if one of the conditions to omit .debug_gdb_scripts is true.

[bjorn3]

The function to insert this section is called at https://github.com/rust-lang/rust/blob/8c0b4f67c9b4bf477df38c16669fd576d46a2b3d/compiler/rustc_codegen_ssa/src/base.rs#L464

[kartva]

I'm interested in working on this issue.

The code you've linked (https://github.com/rust-lang/rust/blob/ab0f3e680e4fd50218914b8afa6900a67377721c/compiler/rustc_codegen_llvm/src/debuginfo/gdb.rs) seems to already contain logic to add pretty-printers. What exactly is the issue here?

[bjorn3]

That is the implementation in the LLVM backend. We need a separate implementation in rustc_codegen_cranelift.

[kernel-loophole]

@bjorn3 is this issue still open .wanted to work on this .Looking forward to hear from you .

[bjorn3]

Yes, this change is still wanted. However someone else also asked if they could pick it up at #1462 (comment) a couple of days ago, so I would like to give them a chance first.

[kernel-loophole]

thanks for your response ,i also add the comment on #1462 if the person wanted to work ,i can help.

[kernel-loophole]

@bjorn3 i ask the person and said that i can pick this

[kernel-loophole]

@bjorn3 should a create sprit module for gdb and call in the base.rs file as in the https://github.com/rust-lang/rust/blob/7606c13961ddc1174b70638e934df0439b7dc515/compiler/rustc_codegen_llvm/src/debuginfo/gdb.rs#L85-L117

[bjorn3]

All code can probably be placed at

rustc_codegen_cranelift/src/driver/aot.rs

Line 396 in 253436c

The if block above is an example for how to add a section to the object file.

[kernel-loophole]

@bjorn3 any project which use the cranelift backend ,needed to test it

[bjorn3]

You can build hello world with rustc_codegen_cranelift and then check if the .debug_gdb_scripts section is present in the executable.