site-settings: Cannot read property 'query' of undefined

[haraldschilly]

while doing some dev, I saw this. I think I was briefly disconnected when this happened.

Uncaught (in promise) TypeError: Cannot read property 'query' of undefined
    at SiteSettingsComponent.eval (site-settings.tsx?0ae8:110)
    at step (site-settings.tsx?0ae8:4)
    at Object.eval [as next] (site-settings.tsx?0ae8:4)
    at fulfilled (site-settings.tsx?0ae8:4)

break is in async load():

    for (const x of result.query.site_settings) {   <<<<<<<<<<<<<<<<<<<<<
      data[x.name] = x.value;
    }

[haraldschilly]

I'm wondering what the type signature of query in result = await query(...) is. Should it maybe throw an error if it is about to return something that's nullish? Or at least make result.query optional? hmm …

[williamstein]

Query should never returned undefined. I just look through the codepaths and can't figure out how that could happen. Note that I just rewrote and refactored ALL of the relevant code in typescript related to this in smc-webapp/client/, so at least it is readable.

Was this something repeatable for you, or was it caused by your connection dropping and resuming at just the right moment and you couldn't get it to happen again? I'm guessing yes, since you say

"I think I was briefly disconnected when this happened."

I'm going to delete some deprecated code in the relevant code path and push that, but I definitely don't know how to fix this bug unless there is some clue about how to reproduce it. Can you try to reproduce this?

[williamstein]

I did find that the site settings toggle in the admin page gets all broken when you disconnect from the internet then try to click it, then connect again. You have to switch away from the admin page and back again. The other toggles work much more robustly...