project startup crash/sshd related

[haraldschilly]

this is a weird exception, no idea how this can happen, but in general it could. the goal of this ticket is to catch errors launching this script, especially when it no longer exists.

2023-11-28T07:58:38.560Z: cocalc:error:project:BUG (uncaughtException)
BUG ****************************************************************************
 {"errno":-2,"code":"ENOENT","syscall":"spawn bash","path":"bash","spawnargs":["/cocalc/kucalc-start-sshd.sh"]} uncaughtException Error: spawn bash ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

Error: spawn bash ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
[INFO  tini (1)] Spawned child process 'sh' with pid '7'

[haraldschilly]

ok, this was very weird. The way to shoot yourself in the foot is to set these env variables in the project settings interface:

{"PATH": "/home/user/foo/bin", "LD_LIBRARY_PATH": "/home/user/foo/lib"}

I think we shouldn't filter or mangle setting these env variables – rather make sure the project starts up fine (it does) and is robust after "crippling" the PATH env var while it runs.