Skip to content

Dropdown: Adds action variant #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Dropdown: Adds action variant #2163

wants to merge 14 commits into from

Conversation

pulkonet
Copy link
Contributor

@pulkonet pulkonet commented Jul 11, 2019 •
edited
Loading

Fixes #2162

Additional description

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@interactivellama
Copy link
Contributor

interactivellama commented Aug 20, 2019 •
edited
Loading

Instead of variant I'd like to propose an isAction prop. Dropdown already has a crazy amount of props, but i'm not sure this is a variant in that it doesn't change much markup, nor UX patterns.

As the trigger button, I think Breadcrumb should take care of that. To be more specific, please React.cloneElement the Dropdown inside of Breadcrumb and if no children exist, add the CustomTrigger child that you need for BreadCrumb to look correct.

Here is an example of closing elements passed in https://github.com/salesforce/design-system-react/blob/combobox_props/components/alert/index.jsx#L162

@pulkonet Does that make sense?

@stale
Copy link

stale bot commented Nov 8, 2019

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

@stale stale bot added the stale label Nov 8, 2019
@stale stale bot closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlygagnon davidlygagnon davidlygagnon left review comments

Assignees

@garygong garygong

Labels
cla:signed stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumb: Overflow menu items should be blue. Button width is too wide
4 participants
@pulkonet @interactivellama @davidlygagnon @garygong