Skip to content

Deobfuscate _getConvexHullPointsForDrawable and remove unnecessary hull.js dependency #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented May 24, 2019

Resolves

Resolves #455

Proposed Changes

This PR makes two changes (which I will gladly separate if needed!):

  • It re-annotates, and changes some of the variable names used in, the convex hull calculation code for _getConvexHullPointsForDrawable. This should make it a bit clearer to understand.
  • It removes the dependency on, and use of, hull.js. In discovering how the hull algorithm works, I have confirmed that the hull it generates is already convex, and thus there is no need to bring in an external dependency to make sure it's extra-convex.

Reason for Changes

These changes make the codebase more friendly to those looking over it for the first time.

(Also, cwillisf, I couldn't find a description of this algorithm anywhere in Numerical Recipes. How could you lie to me like this 😛)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need hull.js?
2 participants