Handle auto-scrolling and highlighting list monitor index #5961
Conversation
scratchfoundation/scratch-gui#5961 :5961 Handle auto-scrolling and highlighting list monitor index
|
@apple502j thanks for your work on this, and sorry it took a while for us to look at it. We decided that our design team will need to make some decisions before we can proceed. We'll need to decide exactly what behavior we want, e.g. will making this change now break existing 3.0 projects that expect no auto-scrolling, exactly when should auto-scrolling occur vs. not, and should the highlight fade as in 2.0. We will also need to assess performance to make sure this doesn't slow things down, and also ideally add unit and integration tests where possible. We're going to close this for now, and possibly re-open if we decide to return to it. |
|
I know this is closed, but I've been using it in my own Scratch build because it's great, and more importantly Eric mentioned that LLK might returned to it in the future. So, I wanted to write a note about some odd behavior I noticed with this PR. If you get the same item from a list repeatedly, the list number will only be highlighted the first time it is accessed. You need to highlight a different number before the first number can be highlighted again. For example: Logically, I would think that if I press the up arrow, I made the same program in Scratch 2, and I confirmed that pressing the up arrow makes |
scratchfoundation/scratch-vm#2507 must be merged first
Resolves
GUI part for these issues:
Resolves scratchfoundation/scratch-vm#1385
Resolves scratchfoundation/scratch-vm#1386
Proposed Changes
Adds list index highlighting and list auto-scrolling feature (although the bugtracker says lack of auto-scrolling is a bug)
When a list monitor receives update to its
highlightItem, it cancels the setTimeout (which i'll mention below), and does two things:highlightItemswhich is a Map (not immutable) of number to setTimeout which unhighlights it after 500mshighlightItemandhighlightItems, which scrolls to added item (list-monitor-scroller L87)When highlighting $control-primary is used.
Note that we pass stringified version of highlightItems to List so that it re-renders - it's PureComponent and doesn't re-render when unhighlighting by itself.
Reason for Changes
compatibility with Scratch 2.0
Test Coverage
Attached a project sb3 - rename and open. click green flag, go to fullscreen, click the stage (not the stage monitor), try pressing arrow keys!
scrollable-list.sb3.zip