Skip to content

scratch-vm should not depend on "latest" scratch-svg-renderer #1650

Open
@fsih

Description

@fsih

https://github.com/LLK/scratch-vm/blob/develop/package.json#L74

scratch-vm should depend on a fixed version of scratch-svg-renderer. Right now scratch-svg-renderer dependency is only used to make the playground work, so the only potential issue is the playground unexpectedly beginning to fail. If we accidentally depend on it elsewhere (vm relies on GUI to hand it an instance of SVGRenderer, so it would be easy to mistakenly create a copy from its own dependency) then all builds depending on latest could be broken by changes to scratch-svg-renderer.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions