Improve test coverage

Author: pmachapman

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-history-list/draft-history-entry/draft-history-entry.component.spec.ts

@@ -109,6 +109,7 @@ describe('DraftHistoryEntryComponent', () => {
       expect(component.buildRequestedByUserName).toBe('user-display-name');
       expect(component.buildRequestedByDate).toBe('formatted-date');
       expect(component.canDownloadBuild).toBe(true);
+      expect(component.columnsToDisplay).toEqual(['bookNames', 'source', 'target']);
       expect(component.hasDetails).toBe(true);
       expect(component.entry).toBe(entry);
       expect(component.sourceLanguage).toBe('fr');
@@ -120,6 +121,52 @@ describe('DraftHistoryEntryComponent', () => {
           target: 'tar'
         }
       ]);
+      expect(component.trainingDataOpen).toBe(false);
+    }));
+
+    it('should handle builds where the draft cannot be downloaded yet', fakeAsync(() => {
+      when(mockedI18nService.localizeBook('GEN')).thenReturn('Genesis');
+      when(mockedI18nService.localizeBook('EXO')).thenReturn('Exodus');
+      const targetProjectDoc = {
+        id: 'project01'
+      } as SFProjectProfileDoc;
+      when(mockedSFProjectService.getProfile('project01')).thenResolve(targetProjectDoc);
+      const sourceProjectDoc = {
+        id: 'project02'
+      } as SFProjectProfileDoc;
+      when(mockedSFProjectService.getProfile('project02')).thenResolve(sourceProjectDoc);
+      const entry = {
+        engine: {
+          id: 'project01'
+        },
+        additionalInfo: {
+          trainingScriptureRanges: [{ projectId: 'project02', scriptureRange: 'EXO' }],
+          translationScriptureRanges: [{ projectId: 'project01', scriptureRange: 'GEN' }]
+        }
+      } as BuildDto;
+
+      // SUT
+      component.entry = entry;
+      tick();
+      fixture.detectChanges();
+
+      expect(component.bookNames).toEqual(['Genesis']);
+      expect(component.buildRequestedByUserName).toBeUndefined();
+      expect(component.buildRequestedByDate).toBe('');
+      expect(component.canDownloadBuild).toBe(false);
+      expect(component.columnsToDisplay).toEqual(['bookNames', 'source', 'target']);
+      expect(component.hasDetails).toBe(true);
+      expect(component.entry).toBe(entry);
+      expect(component.sourceLanguage).toBe('');
+      expect(component.targetLanguage).toBe('');
+      expect(component.trainingData).toEqual([
+        {
+          bookNames: ['Exodus'],
+          source: '',
+          target: ''
+        }
+      ]);
+      expect(component.trainingDataOpen).toBe(true);
     }));
 
     it('should handle builds with additional info referencing a deleted user', fakeAsync(() => {

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.spec.ts

@@ -149,6 +149,63 @@ describe('EditorDraftComponent', () => {
     expect(component.draftText.editor!.getContents().ops).toEqual(draftDelta.ops);
   }));
 
+  it('should support a timestamp earlier than the oldest draft', fakeAsync(() => {
+    const testProjectDoc: SFProjectProfileDoc = {
+      data: createTestProjectProfile()
+    } as SFProjectProfileDoc;
+    when(mockDraftGenerationService.draftExists(anything(), anything(), anything())).thenReturn(of(true));
+    when(mockDraftGenerationService.getGeneratedDraftHistory(anything(), anything(), anything())).thenReturn(
+      of(draftHistory)
+    );
+    when(mockActivatedProjectService.changes$).thenReturn(of(testProjectDoc));
+    spyOn<any>(component, 'getTargetOps').and.returnValue(of(targetDelta.ops!));
+    when(mockDraftHandlingService.getDraft(anything(), anything())).thenReturn(of(cloneDeep(draftDelta.ops!)));
+    when(mockDraftHandlingService.draftDataToOps(anything(), anything())).thenReturn(draftDelta.ops!);
+    when(mockDraftHandlingService.isDraftSegmentMap(anything())).thenReturn(false);
+
+    // Set the date to a time before the earliest draft
+    fixture.componentInstance.timestamp = new Date('2024-03-22T03:02:01Z');
+
+    // SUT
+    fixture.detectChanges();
+    tick(EDITOR_READY_TIMEOUT);
+
+    verify(mockDraftHandlingService.getDraft(anything(), anything())).once();
+    verify(mockDraftHandlingService.draftDataToOps(anything(), anything())).once();
+    expect(component.draftCheckState).toEqual('draft-present');
+    expect(component.draftText.editor!.getContents().ops).toEqual(draftDelta.ops);
+  }));
+
+  it('should support a timestamp close to the oldest draft', fakeAsync(() => {
+    const testProjectDoc: SFProjectProfileDoc = {
+      data: createTestProjectProfile()
+    } as SFProjectProfileDoc;
+    when(mockDraftGenerationService.draftExists(anything(), anything(), anything())).thenReturn(of(true));
+    when(mockDraftGenerationService.getGeneratedDraftHistory(anything(), anything(), anything())).thenReturn(
+      of(draftHistory)
+    );
+    when(mockActivatedProjectService.changes$).thenReturn(of(testProjectDoc));
+    spyOn<any>(component, 'getTargetOps').and.returnValue(of(targetDelta.ops!));
+    when(mockDraftHandlingService.getDraft(anything(), anything())).thenReturn(of(cloneDeep(draftDelta.ops!)));
+    when(mockDraftHandlingService.draftDataToOps(anything(), anything())).thenReturn(draftDelta.ops!);
+    when(mockDraftHandlingService.isDraftSegmentMap(anything())).thenReturn(false);
+
+    // Set the date to a time just before the earliest draft
+    // This will account for the delay in storing the draft
+    const timestamp = new Date(draftHistory[0].timestamp);
+    timestamp.setMinutes(timestamp.getMinutes() - 10);
+    fixture.componentInstance.timestamp = timestamp;
+
+    // SUT
+    fixture.detectChanges();
+    tick(EDITOR_READY_TIMEOUT);
+
+    verify(mockDraftHandlingService.getDraft(anything(), anything())).once();
+    verify(mockDraftHandlingService.draftDataToOps(anything(), anything())).once();
+    expect(component.draftCheckState).toEqual('draft-present');
+    expect(component.draftText.editor!.getContents().ops).toEqual(draftDelta.ops);
+  }));
+
   it('should return ops and update the editor when no revision', fakeAsync(() => {
     const testProjectDoc: SFProjectProfileDoc = {
       data: createTestProjectProfile()