Fixup e2e tests

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/e2e/characterize-tests.mts

@@ -1,8 +1,8 @@
 #!/usr/bin/env -S deno run --allow-run --allow-env --allow-sys --allow-read --allow-write --unstable-sloppy-imports
 import { chromium } from "npm:playwright";
 import { preset } from "./e2e-globals.ts";
-import { Utils } from "./e2e-utils.js";
-import { numberOfTimesToAttemptTest } from "./pass-probability-ts";
+import { Utils } from "./e2e-utils.ts";
+import { numberOfTimesToAttemptTest } from "./pass-probability.ts";
 import { ScreenshotContext } from "./presets.ts";
 import { tests } from "./test-definitions.ts";
 
@@ -34,6 +34,8 @@ while (true) {
     console.log(`Saving trace to ${tracePath}`);
     browserContext.tracing.stop({ path: tracePath });
   } finally {
+    await browserContext.close();
+    await browser.close();
     printRetriesForEachTest();
   }
 }

src/SIL.XForge.Scripture/ClientApp/e2e/copy_help_site_screenshots.mts

@@ -6,7 +6,7 @@ const runLogDir = Deno.args[0];
 const helpRepo = Deno.args[1];
 
 if (runLogDir == null || helpRepo == null) {
-  console.error("Usage: ./update_help_site_screenshots.mts <run_log_dir> <help_repo>");
+  console.error("Usage: ./copy_help_site_screenshots.mts <run_log_dir> <help_repo>");
   Deno.exit(1);
 }
 

src/SIL.XForge.Scripture/ClientApp/e2e/e2e.mts

@@ -2,7 +2,7 @@
 import { chromium, firefox, webkit } from "npm:playwright";
 import { logger, preset, ScreenshotContext } from "./e2e-globals.ts";
 import { screenshot } from "./e2e-utils.ts";
-import { numberOfTimesToAttemptTest } from "./pass-probability-ts";
+import { numberOfTimesToAttemptTest } from "./pass-probability.ts";
 import { presets } from "./presets.ts";
 import { tests } from "./test-definitions.ts";
 import testCharacterization from "./test_characterization.json" with { type: "json" };

src/SIL.XForge.Scripture/ClientApp/e2e/pass-probability-ts renamed to src/SIL.XForge.Scripture/ClientApp/e2e/pass-probability.ts

@@ -1,11 +1,11 @@
-import testCharacterization from "./test_characterization.json" with { type: "json" };
+import testCharacterization from './test_characterization.json' with { type: 'json' };
 
 function probabilityOfRegressionGivenPreviousFailureRates(
   initialRuns: number,
   initialFailures: number,
   newFailures: number
 ): number {
-  if (initialFailures > initialRuns) throw new Error("initialFailures must be less than or equal to initialRuns");
+  if (initialFailures > initialRuns) throw new Error('initialFailures must be less than or equal to initialRuns');
 
   // Adding 1 to both the numerator and denominator provides a better estimate of the actual failure rate.
   // If you read explanations of Bayesian statistics, you'll see 1 added when calculating a prior. Just to be clear, I
@@ -40,6 +40,7 @@ function numberOfRunsNeededToAchieveDesiredProbabilityOfRegression(
   desiredProbabilityOfRegression: number
 ): number {
   for (let i = 1; ; i++) {
+    if (i > 100) throw new Error('Number of runs needed to achieve desired probability of regression is too high');
     if (
       probabilityOfRegressionGivenPreviousFailureRates(initialRuns, initialFailures, i) > desiredProbabilityOfRegression
     ) {

src/SIL.XForge.Scripture/ClientApp/e2e/pre_merge_ci.sh

@@ -41,7 +41,8 @@ function shutDownServer() {
 
 function startServer() {
   cd "${SCRIPT_DIR}/../.."
-  local DOTNET_LOG="$(mktemp)"
+  local DOTNET_LOG
+  DOTNET_LOG="$(mktemp)"
   output "Logging dotnet output to ${DOTNET_LOG}"
   export ASPNETCORE_ENVIRONMENT="Development"
   nohup dotnet run &>"${DOTNET_LOG}" &

src/SIL.XForge.Scripture/ClientApp/e2e/presets.ts

@@ -1,5 +1,5 @@
 import locales from '../../locales.json' with { type: 'json' };
-import { BrowserName, UserRole } from './e2e-globals.ts';
+import type { BrowserName, UserRole } from './e2e-globals.ts';
 import { E2ETestRunLogger } from './e2e-test-run-logger.ts';
 import { Utils } from './e2e-utils.ts';
 

src/SIL.XForge.Scripture/ClientApp/e2e/record_mobile_checking_videos.mts

@@ -3,6 +3,8 @@ import { chromium, devices, expect } from "npm:@playwright/test";
 import { Page } from "npm:playwright";
 import locales from "../../locales.json" with { type: "json" };
 
+// This is a legacy script that is left here for future reference. It works, but is not currently used by the tests.
+
 const typingDelayFactor = 1; // reduce to 0 to speed up typing
 
 // Trick TypeScript into not complaining that the document isn't defined for functions that are actually evaluated in