Skip to content

Rename resolves and rejects assertions #187

Open
@mantoni

Description

@mantoni

The resolves and rejects assertions diverge from the naming convention use by Sinon assertions. In Sinon, resolves and rejects are used to program a stub or a fake, e.g. sinon.fake.resolves(42). The Sinon assertions to verify promises are sinon.assert.resolved(...) and sinon.assert.rejected(...).

I would therefore like to propose changing the names as follows:

  • resolves -> resolved
  • rejects -> rejected
  • toResolveWith -> toHaveBeenResolved
  • toRejectWith -> toHaveBeenRejected

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions