Skip to content

refactor: add protocol support to stats/base/variancewd #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: add protocol support to stats/base/variancewd #5831

wants to merge 1 commit into from
+0 −0

Conversation

gkbishnoi07
Copy link
Contributor

@gkbishnoi07 gkbishnoi07 commented Mar 6, 2025 •
edited
Loading

Resolves #5691

Description

What is the purpose of this pull request?

This pull request:

Refactor and add protocol support

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Mar 6, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 6, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 6, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/variancewd $\color{red}297/340$
$\color{green}+87.35\%$ 		$\color{red}17/18$
$\color{green}+94.44\%$ 		$\color{red}2/3$
$\color{green}+66.67\%$ 		$\color{red}297/340$
$\color{green}+87.35\%$

The above coverage report was generated for the changes in this PR.

@gkbishnoi07 gkbishnoi07 force-pushed the variancewd branch 3 times, most recently from 9e1d8f3 to d43ad21 Compare March 6, 2025 23:16
@gkbishnoi07
Copy link
Contributor Author

@Planeshifter @anandkaranubc ready for review

@gkbishnoi07
Copy link
Contributor Author

@kgryte PTAL

kgryte
kgryte reviewed Mar 18, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/variancewd/lib/ndarray.js Outdated
var i;

n = N - correction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you reorder these statements?

kgryte
kgryte reviewed Mar 18, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/variancewd/lib/variancewd.js Outdated
* @returns {number} variance
*
* @example
* var x = [ 1.0, -2.0, 2.0 ];
* var mask = [ 0, 0, 1 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a mask array in this example? This is all wrong.

@gkbishnoi07
Copy link
Contributor Author

@kgryte I'm considering closing this PR and opening a new one due to some misunderstanding. The issue was caused by a problem with my local setup, which is now resolved. Apologies for the confusion.

@gkbishnoi07
Copy link
Contributor Author

@kgryte Would you prefer that I open a new PR or continue with this one?

kgryte
kgryte requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs significant clean-up. Based on some of the edits, it looks like you may have used AI/LLMs. Please don't. Before using AI, do things manually to start so that you properly learn conventions and develop an understanding of how to program AI to provide proper assistance.

@kgryte
Copy link
Member

kgryte commented Mar 18, 2025

@gkbishnoi07 You should not open another PR. You should focus on cleaning up your existing PRs. Otherwise, you will just be creating unnecessary work.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 18, 2025
@gkbishnoi07
Copy link
Contributor Author

@gkbishnoi07 You should not open another PR. You should focus on cleaning up your existing PRs. Otherwise, you will just be creating unnecessary work.

@kgryte I'm really sorry for what happened. It was a misunderstanding, and there was also an issue with the local setup. I assure you it won't happen again in the future.

@gkbishnoi07 gkbishnoi07 reopened this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/variancewd
3 participants
@gkbishnoi07 @stdlib-bot @kgryte