Skip to content

Commit 38834b7

Browse files
committed
minor #15611 [DependencyInjection] Improve url env var processor with type cast (noniagriconomie)
This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Improve url env var processor with type cast Hi I've tried on my symfony app v4.4, the `env(url:FOO)` env processor reading the doc at https://symfony.com/doc/4.4/configuration/env_var_processors.html --- Without the changes proposed in this PR, I got: - with definition like this in an `app.yaml` file - `service.port: '%env(key:port:url:SERVICE_DSN)%'` - the error - `Invalid type for path "service.port". Expected one of "bool", "int", "float", "string", but got one of "bool", "int", "float", "string", "array".` but it works only like this: - `service.port: '%env(int:key:port:url:SERVICE_DSN)%'` - same with `string:` for example a `key:user` or a `key:pass` fields from the url processor --- Thus I am proposing this PR to correct the usage of this processor If I am doing something wrong/incorrect, please answer what/why and feel free to close this PR! Thank you :) -------- Symfony 4.4.29 PHP 7.4.22 Commits ------- b396b02 Improve url env var processor with type cast
2 parents da22a89 + b396b02 commit 38834b7

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

configuration/env_var_processors.rst

+9-9
Original file line numberDiff line numberDiff line change
@@ -549,9 +549,9 @@ Symfony provides the following env var processors:
549549
clients:
550550
default:
551551
hosts:
552-
- { host: '%env(key:host:url:MONGODB_URL)%', port: '%env(key:port:url:MONGODB_URL)%' }
553-
username: '%env(key:user:url:MONGODB_URL)%'
554-
password: '%env(key:pass:url:MONGODB_URL)%'
552+
- { host: '%env(string:key:host:url:MONGODB_URL)%', port: '%env(int:key:port:url:MONGODB_URL)%' }
553+
username: '%env(string:key:user:url:MONGODB_URL)%'
554+
password: '%env(string:key:pass:url:MONGODB_URL)%'
555555
connections:
556556
default:
557557
database_name: '%env(key:path:url:MONGODB_URL)%'
@@ -566,8 +566,8 @@ Symfony provides the following env var processors:
566566
https://symfony.com/schema/dic/services/services-1.0.xsd">
567567
568568
<mongodb:config>
569-
<mongodb:client name="default" username="%env(key:user:url:MONGODB_URL)%" password="%env(key:pass:url:MONGODB_URL)%">
570-
<mongodb:host host="%env(key:host:url:MONGODB_URL)%" port="%env(key:port:url:MONGODB_URL)%"/>
569+
<mongodb:client name="default" username="%env(string:key:user:url:MONGODB_URL)%" password="%env(string:key:pass:url:MONGODB_URL)%">
570+
<mongodb:host host="%env(string:key:host:url:MONGODB_URL)%" port="%env(int:key:port:url:MONGODB_URL)%"/>
571571
</mongodb:client>
572572
<mongodb:connections name="default" database_name="%env(key:path:url:MONGODB_URL)%"/>
573573
</mongodb:config>
@@ -581,12 +581,12 @@ Symfony provides the following env var processors:
581581
'default' => [
582582
'hosts' => [
583583
[
584-
'host' => '%env(key:host:url:MONGODB_URL)%',
585-
'port' => '%env(key:port:url:MONGODB_URL)%',
584+
'host' => '%env(string:key:host:url:MONGODB_URL)%',
585+
'port' => '%env(int:key:port:url:MONGODB_URL)%',
586586
],
587587
],
588-
'username' => '%env(key:user:url:MONGODB_URL)%',
589-
'password' => '%env(key:pass:url:MONGODB_URL)%',
588+
'username' => '%env(string:key:user:url:MONGODB_URL)%',
589+
'password' => '%env(string:key:pass:url:MONGODB_URL)%',
590590
],
591591
],
592592
'connections' => [

0 commit comments

Comments
 (0)