Open
Description
> @OskarStark I'm wondering if we should create a checklist of things we should not forget when adding a new mailer/notifier (and publish it in the docs). WDYT?
Makes sense, if I find some spare time, I will do it.
PS: Another option would be to have dedicated Carsonbot comment with the checklist when a new bridge is added
Originally posted by @OskarStark in symfony/symfony#53573 (comment)
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
xabbuh commentedon Jan 18, 2024
Some things I have regular added in the past which are not that obvious (easy to miss):
UnsupportSchemeException
,UnsupportedSchemeExceptionTest
FACTORY_CLASSES
constant of the component'sTransport
classOskarStark commentedon Jan 18, 2024
Mostly copy pasted from old bridges
OskarStark commentedon Jan 18, 2024
#[\SensitiveParameter]
should be used for sensitive propertiesOskarStark commentedon Jan 18, 2024
symfony/symfony-docs
repo, maybe with an example (already merged PR)symfony/recipes
repo, maybe with an example (already merged PR)smnandre commentedon Jan 18, 2024
javiereguiluz commentedon Jan 25, 2024
Folks, this issue looks mostly related to Symfony code, not docs, right?
OskarStark commentedon Jan 25, 2024
Yes, but Fabien wants to have a checklist in the docs as first step.
Anyone willing to create an initial PR?