[Console] allow the console logging handler to work and prevent propagation only when interactive

[dkarlovi]

Description

Let's assume this setup

monolog:
    handlers:
        console:
            type: console
            interactive_only: true # this is new
        logstash:
            type: stream
            path: "php://stderr"
            formatter: 'monolog.formatter.logstash'

Now let's assume we're running some command meant for non-interactive use, like messenger:consume, see #57776.

When running the command using logging interactively (user running the command and watching the output) currently, you'll get both the command output, console output and the logstash JSON, which is creating a giant mess of output.

What would be better is to allow the logger to know if there's a user watching the output (command is in an interactive shell or not) and then:

1. output console and skip logstash (prevent bubble) when interactive
2. skip console and only output logstash when not interactive

This would mean the logging is adjusted to the current runtime better automatically.

Example

No response

[dkarlovi]

/cc @ro0NL IIRC we spoke about this in several other issues?

[dkarlovi]

IMO the described feature would serve a similar purpose without needing to do any special setup per environment or custom handlers, just with config like shown.

[dkarlovi]

That's precisely what the interactive / non interactive thing is meant to signal: has user or not.

[stof]

if you don't configure your cron with -n, it is still probably running in non-interactive mode due to the way the command is launched (unless your cron launches the command in a tty, but then, what does it do to provide input during interaction ?)

[dkarlovi]

@ro0NL yes, this would be opt-in since it's a new minor feature, otherwise it would be a BC break, no?

[dkarlovi]

BTW I've checked this and the issue is, ConsoleHandler takes OutputInterface, but we need the InputInterface too because that's where isInteractive() is.

symfony/src/Symfony/Bridge/Monolog/Handler/ConsoleHandler.php

Line 63 in 3d4e0d6

private ?OutputInterface $output = null,

The idea might be to add it as the last arg and make it nullable and wire it up only if interactive_only: true is set, this would be the opt-in. Does that make sense?

[dkarlovi]

@stof (I'm pinging you because you seem to be the Monolog Bundle guy), assuming I want to work on this, am I right to understand this would be two separate PRs?

1. monorepo PR, add support for injecting InputInterface to ConsoleHandler
2. Monolog bundle PR, add support to configure injecting it to opt in