Skip to content

Commit 9a25a16

Browse files
committed
minor #1369 [CI][Puppeteer] Add timeout, use new headless mode, and disable sandbox (Kocal)
This PR was merged into the main branch. Discussion ---------- [CI][Puppeteer] Add timeout, use new headless mode, and disable sandbox | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Since a moment, the Ubuntu CI failed because Puppeteer was unable to launch, and leads to timeout. Let's see if using new headless mode fix it. Commits ------- d3c7d48 [CI][Puppeteer] Add timeout, use new headless mode, and disable sandbox
2 parents 0bc8b1d + d3c7d48 commit 9a25a16

File tree

3 files changed

+140
-137
lines changed

3 files changed

+140
-137
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
"postcss-loader": "^7.0.0 || ^8.1.0",
8181
"preact": "^10.5.0",
8282
"preact-compat": "^3.17.0",
83-
"puppeteer": "^23.2.2",
83+
"puppeteer": "^24.6.0",
8484
"react": "^18.0.0",
8585
"react-dom": "^18.0.0",
8686
"sass": "^1.17.0",

test/functional.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,14 @@ describe('Functional tests using webpack', function() {
8181
this.timeout(10000);
8282

8383
before(function(done) {
84-
puppeteer.launch().then(_browser => {
84+
this.timeout(15000);
85+
puppeteer.launch({ headless: 'new', timeout: 14000, args: ['--no-sandbox', '--disable-setuid-sandbox'] }).then(_browser => {
8586
browser = _browser;
8687
done();
88+
}).catch(err => {
89+
console.log('Unable to launch Puppeteer');
90+
console.log(err);
91+
throw err;
8792
});
8893
});
8994

0 commit comments

Comments
 (0)