Skip to content

Make mdast-util-gfm-autolink-literal Compatible with Older Browsers (Chrome 49): Remove Lookbehind Assertion #17

Duplicate of#10
@consistent-k

Description

@consistent-k

Initial checklist

  • I read the support docs
    I read the contributing guide
    I agree to follow the code of conduct
    I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package

mdast-util-gfm-autolink-literal@latest

Steps to reproduce

  1. Use mdast-util-gfm-autolink-literal in an environment running Chrome 49.
  2. Process a markdown file or text that includes email addresses triggering the regex:
[/(?<=^|\s|\p{P}|\p{S})([-.\w+]+)@([-\w]+(?:\.[-\w]+)+)/gu, findEmail]

Observe that Chrome 49 throws a SyntaxError: Invalid regular expression due to the unsupported lookbehind assertion.

Actual behavior

Chrome 49 throws a syntax error because it does not support the (?<=...) lookbehind assertion used in the regex. This stops the library from correctly parsing autolinked email addresses.

Expected behavior

The regex should be modified to avoid the use of lookbehind assertions (e.g., by using non-capturing groups or an alternative matching strategy) so that it can run in legacy browsers like Chrome 49 without throwing an error. This would improve compatibility and allow users with older browser versions to use the library without issues.

Additional context:
Consider replacing the current regex

/(?<=^|\s|\p{P}|\p{S})([-.\w+]+)@([-\w]+(?:\.[-\w]+)+)/gu

with a version that does not rely on lookbehind assertions, such as:

/(?:^|[\s\p{P}\p{S}])(([-.\w+]+)@([-\w]+(?:\.[-\w]+)+))/gu

Note that the consuming code might need to adjust index access to the matched email address.

Thank you for your consideration and for maintaining this project!

Runtime

Chrome 49.0.2623.100

Package manager

pnpm@9.12.2

Operating system

window xp

Build and bundle tools

No response

Activity

added
👋 phase/newPost is being triaged automatically
🤞 phase/openPost is being triaged manually
and removed
👋 phase/newPost is being triaged automatically
on Mar 11, 2025
JounQin

JounQin commented on Mar 11, 2025

@JounQin
Member

Please search before creating new issues

github-actions

github-actions commented on Mar 11, 2025

@github-actions
github-actions

github-actions commented on Mar 11, 2025

@github-actions

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

github-actions

github-actions commented on Mar 11, 2025

@github-actions

Hi team! It seems this post is a duplicate, but hasn’t been marked as such. Please post a comment w/ Duplicate of #123(no final .) to do so. See GH docs for more info.

Thanks,
— bb

added
👎 phase/noPost cannot or will not be acted on
and removed
🤞 phase/openPost is being triaged manually
on Mar 11, 2025
JounQin

JounQin commented on Mar 11, 2025

@JounQin
Member

Duplicate of #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @JounQin@consistent-k

        Issue actions

          Make mdast-util-gfm-autolink-literal Compatible with Older Browsers (Chrome 49): Remove Lookbehind Assertion · Issue #17 · syntax-tree/mdast-util-gfm-autolink-literal