Skip to content

Take into account global error handlers #332

Open
@j3j5

Description

@j3j5

Hi there,

I was reading this thread on Twitter by Christian Lück and I immediately thought on Safe.

I just checked and just like on his example, this library uses error_get_last() without accounting for any other global error handlers set by the application. I checked fopen() but I guess the implementation is the same for all functions using error_get_last().

What do you think? Shall this be addressed? Would you like a MR?

Activity

dbrekelmans

dbrekelmans commented on Mar 17, 2022

@dbrekelmans
Collaborator

Yeah, makes sense to me! Looking forward to the PR :)

Keep in mind that this change should be done in the generator, not in the individual generated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @j3j5@dbrekelmans

      Issue actions

        Take into account global error handlers · Issue #332 · thecodingmachine/safe