Use actions.run_shell instead of creating a shell script

A shell script is not runnable on Windows and failed
with `%1 is not a valid Win32 application`.

Author: avdv

haskell/BUILD.bazel

@@ -32,7 +32,6 @@ exports_files(
         "private/coverage_wrapper.sh.tpl",
         "private/ghci_repl_wrapper.sh",
         "private/hie_bios_wrapper.sh",
-        "private/haddock_wrapper.sh.tpl",
         "private/cc_wrapper.py.tpl",
         "private/cc_wrapper_windows.sh.tpl",
         "private/pkgdb_to_bzl.py",

haskell/haddock.bzl

@@ -135,26 +135,7 @@ def _haskell_doc_aspect_impl(target, ctx):
         [lib for li in target[CcInfo].linking_context.linker_inputs.to_list() for lib in li.libraries],
     )
 
-    # TODO(mboes): we should be able to instantiate this template only
-    # once per toolchain instance, rather than here.
-    # TODO(aherrmann): Convert to a standalone sh_binary.
-    # Executable shell script files don't work on Windows.
-    # This fails with `%1 is not a valid Win32 application.`.
-    haddock_wrapper = ctx.actions.declare_file("haddock_wrapper-{}".format(hs.name))
-    ctx.actions.expand_template(
-        template = ctx.file._haddock_wrapper_tpl,
-        output = haddock_wrapper,
-        substitutions = {
-            "%{ghc-pkg}": hs.tools.ghc_pkg.path,  # not mentioned in bash XXX delete?
-            "%{haddock}": shell.quote(hs.tools.haddock.path),
-            # XXX Workaround
-            # https://github.com/bazelbuild/bazel/issues/5980.
-            "%{env}": render_env(hs.env),
-        },
-        is_executable = True,
-    )
-
-    ctx.actions.run(
+    ctx.actions.run_shell(
         inputs = depset(transitive = [
             target[HaskellInfo].package_databases,
             target[HaskellInfo].interface_dirs,
@@ -177,7 +158,21 @@ def _haskell_doc_aspect_impl(target, ctx):
         outputs = [haddock_file, html_dir],
         mnemonic = "HaskellHaddock",
         progress_message = "HaskellHaddock {}".format(ctx.label),
-        executable = haddock_wrapper,
+        command = """
+set -eo pipefail
+
+{env}
+
+# BSD and GNU mktemp are very different; attempt GNU first
+TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t 'haddock_wrapper')
+trap cleanup 1 2 3 6
+cleanup() {{ rm -rf "$TEMP"; }}
+# XXX Override TMPDIR to prevent race conditions on certain platforms.
+# This is a workaround for
+# https://github.com/haskell/haddock/issues/894.
+TMPDIR=$TEMP {haddock} "$@"
+cleanup
+        """.format(env = render_env(hs.env), haddock = shell.quote(hs.tools.haddock.path)),
         arguments = [
             args,
             compile_flags,
@@ -201,12 +196,6 @@ def _haskell_doc_aspect_impl(target, ctx):
 
 haskell_doc_aspect = aspect(
     _haskell_doc_aspect_impl,
-    attrs = {
-        "_haddock_wrapper_tpl": attr.label(
-            allow_single_file = True,
-            default = Label("@rules_haskell//haskell:private/haddock_wrapper.sh.tpl"),
-        ),
-    },
     attr_aspects = ["deps", "exports"],
     required_aspect_providers = [HaskellCcLibrariesInfo],
     toolchains = [

haskell/private/haddock_wrapper.sh.tpl

@@ -28,13 +28,6 @@ shellcheck(
     sh_flavor = "bash",
 )
 
-shellcheck(
-    name = "haddock_wrapper.sh",
-    args = ["$(location @rules_haskell//haskell:private/haddock_wrapper.sh.tpl)"],
-    data = ["@rules_haskell//haskell:private/haddock_wrapper.sh.tpl"],
-    sh_flavor = "bash",
-)
-
 shellcheck(
     name = "netlify-build",
     args = ["$(location @rules_haskell//:.netlify/build.sh)"],