From d0c3f21de31fd552ae4397de0944a412108c076c Mon Sep 17 00:00:00 2001
From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com>
Date: Thu, 24 Apr 2025 16:26:51 -0400
Subject: [PATCH 1/2] remove dtor logging

---
 src/viam/sdk/log/logging.hpp    | 4 ++++
 src/viam/sdk/module/service.cpp | 5 ++---
 src/viam/sdk/robot/client.cpp   | 4 ++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/viam/sdk/log/logging.hpp b/src/viam/sdk/log/logging.hpp
index aa86c40d2..6bb568b1e 100644
--- a/src/viam/sdk/log/logging.hpp
+++ b/src/viam/sdk/log/logging.hpp
@@ -150,6 +150,8 @@ BOOST_LOG_ATTRIBUTE_KEYWORD_TYPE(attr_time,
 /// @ingroup Log
 ///
 /// Use this macro to generate log messages pertaining to the SDK at large.
+/// @warning Using this macro outside of the lifetime of LogManager is UB and for this reason
+/// logging in destructors should be done with caution or avoided entirely.
 #define VIAM_SDK_LOG(level) VIAM_SDK_LOG_IMPL(::viam::sdk::LogManager::get().global_logger(), level)
 
 /// @brief Log macro for resource-level logs.
@@ -158,6 +160,8 @@ BOOST_LOG_ATTRIBUTE_KEYWORD_TYPE(attr_time,
 /// This macro can only be called from the definition of a member function of a class inheriting
 /// @ref Resource. It will log messages to the log source of that specific resource, allowing
 /// resource-level log filtering.
+/// @warning Using this macro outside of the lifetime of LogManager is UB and for this reason
+/// logging in destructors should be done with caution or avoided entirely.
 #define VIAM_RESOURCE_LOG(level) VIAM_SDK_LOG_IMPL(this->logger_, level)
 
 }  // namespace sdk
diff --git a/src/viam/sdk/module/service.cpp b/src/viam/sdk/module/service.cpp
index b270f629d..30aaeaef5 100644
--- a/src/viam/sdk/module/service.cpp
+++ b/src/viam/sdk/module/service.cpp
@@ -254,15 +254,14 @@ ModuleService::ModuleService(int argc,
 }
 
 ModuleService::~ModuleService() {
-    // TODO(RSDK-5509): Run registered cleanup functions here.
-    VIAM_SDK_LOG(info) << "Shutting down gracefully.";
+    std::cout << "Shutting down gracefully.";
     server_->shutdown();
 
     if (parent_) {
         try {
             parent_->close();
         } catch (const std::exception& exc) {
-            VIAM_SDK_LOG(error) << exc.what();
+            std::cerr << exc.what();
         }
     }
 }
diff --git a/src/viam/sdk/robot/client.cpp b/src/viam/sdk/robot/client.cpp
index 6e172ac24..5ed2f42f0 100644
--- a/src/viam/sdk/robot/client.cpp
+++ b/src/viam/sdk/robot/client.cpp
@@ -120,9 +120,9 @@ RobotClient::~RobotClient() {
         try {
             this->close();
         } catch (const std::exception& e) {
-            VIAM_SDK_LOG(error) << "Received err while closing RobotClient: " << e.what();
+            std::cerr << "Received err while closing RobotClient: " << e.what();
         } catch (...) {
-            VIAM_SDK_LOG(error) << "Received unknown err while closing RobotClient";
+            std::cerr << "Received unknown err while closing RobotClient";
         }
     }
 }

From a53494ac007e30365a008c36e88662edefb9cfcb Mon Sep 17 00:00:00 2001
From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com>
Date: Thu, 24 Apr 2025 16:32:09 -0400
Subject: [PATCH 2/2] newline

---
 src/viam/sdk/module/service.cpp | 2 +-
 src/viam/sdk/robot/client.cpp   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/viam/sdk/module/service.cpp b/src/viam/sdk/module/service.cpp
index 30aaeaef5..ae7c5707a 100644
--- a/src/viam/sdk/module/service.cpp
+++ b/src/viam/sdk/module/service.cpp
@@ -254,7 +254,7 @@ ModuleService::ModuleService(int argc,
 }
 
 ModuleService::~ModuleService() {
-    std::cout << "Shutting down gracefully.";
+    std::cout << "Shutting down gracefully.\n";
     server_->shutdown();
 
     if (parent_) {
diff --git a/src/viam/sdk/robot/client.cpp b/src/viam/sdk/robot/client.cpp
index 5ed2f42f0..4d70ae4d1 100644
--- a/src/viam/sdk/robot/client.cpp
+++ b/src/viam/sdk/robot/client.cpp
@@ -120,9 +120,9 @@ RobotClient::~RobotClient() {
         try {
             this->close();
         } catch (const std::exception& e) {
-            std::cerr << "Received err while closing RobotClient: " << e.what();
+            std::cerr << "Received err while closing RobotClient: " << e.what() << "\n";
         } catch (...) {
-            std::cerr << "Received unknown err while closing RobotClient";
+            std::cerr << "Received unknown err while closing RobotClient\n";
         }
     }
 }