Skip to content

nextTick implementation breaks with core-js@3 Promise polyfill on Tizen 2016 #11325

Open
@victortwc

Description

@victortwc

Version

2.6.11

Steps to reproduce

Just cross-linking the issues here, it was opened in core-js repo:
zloirock/core-js#814

The reproduction is not easily doable as it requires a Samsung Tizen 2016 device (which I have because I develop specifically for TVs).

What is expected?

UI updates correctly after events

What is actually happening?

UI will only update if another task is queue.


In the nextTick implementation there's a check for isIOS to trigger an extra setTimeout which, while hacky, works also for Tizen 2016.

Perhaps a PR could be made adding an exception for Samsung Tizen as well?

Activity

posva

posva commented on Apr 18, 2020

@posva
Member

A boiled down repro is still required

victortwc

victortwc commented on Apr 18, 2020

@victortwc
Author

Would you like me to prepare a Tizen package with minimal reproduction code @posva ?

posva

posva commented on Apr 19, 2020

@posva
Member

The package could be useful for anybody who can reproduce it. A code sample would be useful
It’s unclear why core js plays a role here though. If you have a simple fix, I think it would be better to send a PR

victortwc

victortwc commented on Apr 19, 2020

@victortwc
Author

Core-js plays a role in the sense that Vue-cli 4 is using core-js@3 by default for polyfills. The implementation breaks in core-js@3 but doesn't in core-js2, hence my confusion.

victortwc

victortwc commented on Apr 20, 2020

@victortwc
Author

@posva a simple fix would be to detect Tizen user agent and do the same trick as it's done for iOS (using a setTimeout), but I noticed an impact in performance while doing user interaction e.g with longpress. I'm curious to know why it worked with core-js@2 with no special quirks.

One solution for me to move forward now is to use core-js v2 on this project, but it seems like going against the grain, as v2 is already deprecated in favor of v3. I don't want to send a PR unless it's absolutely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @posva@victortwc

        Issue actions

          nextTick implementation breaks with core-js@3 Promise polyfill on Tizen 2016 · Issue #11325 · vuejs/vue