From e032d5473509a2fb0ef24b8652e593e8ac0193bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9C=A8=E7=BE=BD?= Date: Wed, 31 Oct 2018 10:12:47 +0800 Subject: [PATCH 1/3] Update patch.js Maybe these make more readable --- src/core/vdom/patch.js | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js index 81289f01521..bab295a3888 100644 --- a/src/core/vdom/patch.js +++ b/src/core/vdom/patch.js @@ -23,6 +23,7 @@ import { isDef, isUndef, isTrue, + isFalse, makeMap, isRegExp, isPrimitive @@ -176,24 +177,15 @@ export function createPatchFunction (backend) { setScope(vnode) /* istanbul ignore if */ - if (__WEEX__) { + if (__WEEX__ && (isUndef(data) || isFalse(data.appendAsTree))) { // in Weex, the default insertion order is parent-first. // List items can be optimized to use children-first insertion // with append="tree". - const appendAsTree = isDef(data) && isTrue(data.appendAsTree) - if (!appendAsTree) { - if (isDef(data)) { - invokeCreateHooks(vnode, insertedVnodeQueue) - } - insert(parentElm, vnode.elm, refElm) + if (isDef(data)) { + invokeCreateHooks(vnode, insertedVnodeQueue) } + insert(parentElm, vnode.elm, refElm) createChildren(vnode, children, insertedVnodeQueue) - if (appendAsTree) { - if (isDef(data)) { - invokeCreateHooks(vnode, insertedVnodeQueue) - } - insert(parentElm, vnode.elm, refElm) - } } else { createChildren(vnode, children, insertedVnodeQueue) if (isDef(data)) { @@ -205,11 +197,10 @@ export function createPatchFunction (backend) { if (process.env.NODE_ENV !== 'production' && data && data.pre) { creatingElmInVPre-- } - } else if (isTrue(vnode.isComment)) { - vnode.elm = nodeOps.createComment(vnode.text) - insert(parentElm, vnode.elm, refElm) } else { - vnode.elm = nodeOps.createTextNode(vnode.text) + vnode.elm = isTrue(vnode.isComment) + ? nodeOps.createComment(vnode.text) + : nodeOps.createTextNode(vnode.text) insert(parentElm, vnode.elm, refElm) } } From 26362d774858886515864c6d9f33dd359007df5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9C=A8=E7=BE=BD?= Date: Fri, 14 Dec 2018 17:18:43 +0800 Subject: [PATCH 2/3] Update patch.js --- src/core/vdom/patch.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js index bab295a3888..1ab58a767e1 100644 --- a/src/core/vdom/patch.js +++ b/src/core/vdom/patch.js @@ -177,7 +177,7 @@ export function createPatchFunction (backend) { setScope(vnode) /* istanbul ignore if */ - if (__WEEX__ && (isUndef(data) || isFalse(data.appendAsTree))) { + if (__WEEX__ && (isUndef(data) || !data.appendAsTree)) { // in Weex, the default insertion order is parent-first. // List items can be optimized to use children-first insertion // with append="tree". From e38f9b2c2e100862f11ed254d28edf994abaaf97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9C=A8=E7=BE=BD?= Date: Fri, 14 Dec 2018 17:22:22 +0800 Subject: [PATCH 3/3] Update patch.js remove function isFalse --- src/core/vdom/patch.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js index 1ab58a767e1..93f11d6244a 100644 --- a/src/core/vdom/patch.js +++ b/src/core/vdom/patch.js @@ -23,7 +23,6 @@ import { isDef, isUndef, isTrue, - isFalse, makeMap, isRegExp, isPrimitive