Skip to content

Commit fd9ad4f

Browse files
committed
docs(readme/contrib): clean up README, merge changes from CONTRIBUTING.md and split out DCO
1 parent d8a53ca commit fd9ad4f

File tree

3 files changed

+86
-57
lines changed

3 files changed

+86
-57
lines changed

CONTRIBUTING.md

+14-19
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
# How to contribute
22

3-
etcd is open source, Apache 2.0 licensed and accepts contributions via Github pull requests.
4-
This document outlines some of the conventions on commit message formatting, contact points for developers and other resources to make getting your contribution into etcd easier.
3+
etcd is Apache 2.0 licensed and accepts contributions via Github pull requests. This document outlines some of the conventions on commit message formatting, contact points for developers and other resources to make getting your contribution into etcd easier.
54

65
# Email and chat
76

8-
For simplicity etcd discussions happen on coreos-dev and in #coreos-dev.
9-
As the community grows we will move to a dedicated mailing list and IRC channel.
10-
11-
- Email: [coreos-dev](https://groups.google.com/forum/#!forum/coreos-dev)
7+
- Email: [etcd-dev](http://coreos.com/lists/etcd-dev/)
128
- IRC: #[coreos](irc://irc.freenode.org:6667/#coreos) IRC channel on freenode.org
139

14-
## Getting Started
10+
## Getting started
1511

1612
- Fork the repository on GitHub
1713
- Read the README.md for build instructions
@@ -22,11 +18,11 @@ This is a rough outline of what a contributor's workflow looks like:
2218

2319
- Create a topic branch from where you want to base your work. This is usually master.
2420
- Make commits of logical units.
25-
- Make sure your commit messages are in the proper format, see below
21+
- Make sure your commit messages are in the proper format (see below).
2622
- Push your changes to a topic branch in your fork of the repository.
27-
- Submit a pull request to coreos/etcd
23+
- Submit a pull request to coreos/etcd.
2824

29-
Thanks for you contributions!
25+
Thanks for your contributions!
3026

3127
### Code style
3228

@@ -36,8 +32,7 @@ Please follow this style to make etcd easy to review, maintain and develop.
3632

3733
### Format of the commit message
3834

39-
etcd follow a rough convention for commit messages borrowed from Angularjs.
40-
This is an example of a commit:
35+
etcd follows a rough convention for commit messages borrowed from Angularjs. This is an example of a commit:
4136

4237
```
4338
feat(scripts/test-cluster): add a cluster test command
@@ -46,7 +41,7 @@ This is an example of a commit:
4641
start for debugging.
4742
```
4843

49-
To make it more formal it looks something like this:
44+
The format can be more formally described as follows:
5045

5146
```
5247
<type>(<scope>): <subject>
@@ -56,14 +51,14 @@ To make it more formal it looks something like this:
5651
<footer>
5752
```
5853

59-
The first line is the subject and should not be longer than 70 characters, the second line is always blank and other lines should be wrapped at 80 characters.
60-
This allows the message to be easier to read on github as well as in various git tools.
54+
The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters. This allows the message to be easier to read on github as well as
55+
in various git tools.
6156

6257
### Subject line
6358

64-
The subject line contains succinct description of the change.
59+
The subject line contains a succinct description of the change.
6560

66-
### Allowed <type>
61+
### Allowed <type>s
6762
- feat (feature)
6863
- fix (bug fix)
6964
- docs (documentation)
@@ -72,9 +67,9 @@ The subject line contains succinct description of the change.
7267
- test (when adding missing tests)
7368
- chore (maintain)
7469

75-
### Allowed <scope>
70+
### Allowed <scope>s
7671

77-
Scopes could be anything specifying place of the commit change. For example store, api, etc.
72+
Scopes can be anything specifying the place of the commit change within the repository. For example, "store", "API", etc.
7873

7974
### More details on commits
8075

DCO

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
Developer Certificate of Origin
2+
Version 1.1
3+
4+
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
5+
660 York Street, Suite 102,
6+
San Francisco, CA 94110 USA
7+
8+
Everyone is permitted to copy and distribute verbatim copies of this
9+
license document, but changing it is not allowed.
10+
11+
12+
Developer's Certificate of Origin 1.1
13+
14+
By making a contribution to this project, I certify that:
15+
16+
(a) The contribution was created in whole or in part by me and I
17+
have the right to submit it under the open source license
18+
indicated in the file; or
19+
20+
(b) The contribution is based upon previous work that, to the best
21+
of my knowledge, is covered under an appropriate open source
22+
license and I have the right under that license to submit that
23+
work with modifications, whether created in whole or in part
24+
by me, under the same open source license (unless I am
25+
permitted to submit under a different license), as indicated
26+
in the file; or
27+
28+
(c) The contribution was provided directly to me by some other
29+
person who certified (a), (b) or (c) and I have not modified
30+
it.
31+
32+
(d) I understand and agree that this project and the contribution
33+
are public and that a record of the contribution (including all
34+
personal information I submit with it, including my sign-off) is
35+
maintained indefinitely and may be redistributed consistent with
36+
this project or the open source license(s) involved.

README.md

+36-38
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,28 @@
33
README version 0.3.0
44

55
A highly-available key value store for shared configuration and service discovery.
6-
etcd is inspired by zookeeper and doozer, with a focus on:
6+
etcd is inspired by [Apache ZooKeeper][zookeeper] and [doozer][doozer], with a focus on being:
77

8-
* Simple: curl'able user facing API (HTTP+JSON)
9-
* Secure: optional SSL client cert authentication
10-
* Fast: benchmarked 1000s of writes/s per instance
11-
* Reliable: Properly distributed using Raft
8+
* *Simple*: curl'able user facing API (HTTP+JSON)
9+
* *Secure*: optional SSL client cert authentication
10+
* *Fast*: benchmarked 1000s of writes/s per instance
11+
* *Reliable*: properly distributed using Raft
1212

13-
Etcd is written in Go and uses the [Raft][raft] consensus algorithm to manage a highly-available replicated log.
13+
etcd is written in Go and uses the [Raft][raft] consensus algorithm to manage a highly-available replicated log.
1414

1515
See [etcdctl][etcdctl] for a simple command line client.
1616
Or feel free to just use curl, as in the examples below.
1717

18+
[zookeeper]: http://zookeeper.apache.org/
19+
[doozer]: https://github.com/ha/doozerd
1820
[raft]: http://raftconsensus.github.io/
1921
[etcdctl]: http://github.com/coreos/etcdctl/
2022

2123
## Getting Started
2224

2325
### Getting etcd
2426

25-
The latest release and setup instructions are available at [Github][github-release].
27+
The latest release and setup instructions are available at [GitHub][github-release].
2628

2729
[github-release]: https://github.com/coreos/etcd/releases/
2830

@@ -45,65 +47,65 @@ _NOTE_: you need go 1.2+. Please check your installation with
4547
go version
4648
```
4749

48-
See the [development tools documentation][development-tools.md] for alternative build methods like using Vagrant.
50+
See the [development tools documentation][development-tools] for alternative build methods like using Vagrant.
4951

50-
[development-tools.md]: https://github.com/coreos/etcd/blob/master/Documentation/development-tools.md
52+
[development-tools]: https://github.com/coreos/etcd/blob/master/Documentation/development-tools.md
5153

5254
### Running
5355

54-
First start a single machine cluster of etcd:
56+
First start a single-machine cluster of etcd:
5557

5658
```sh
5759
./bin/etcd
5860
```
5961

6062
This will bring up etcd listening on port 4001 for client communication and on port 7001 for server-to-server communication.
6163

62-
Next lets set a single key and then retrieve it:
64+
Next, let's set a single key, and then retrieve it:
6365

6466
```
6567
curl -L http://127.0.0.1:4001/v2/keys/mykey -XPUT -d value="this is awesome"
6668
curl -L http://127.0.0.1:4001/v2/keys/mykey
6769
```
6870

69-
You have successfully started an etcd on a single machine and written a key to the store. Now it time to dig into the full etcd API and other guides.
71+
You have successfully started an etcd on a single machine and written a key to the store. Now it's time to dig into the full etcd API and other guides.
7072

7173
### Next Steps
7274

73-
- Explore the full [API][api.md].
74-
- Setup a [multi-machine cluster][clustering.md].
75-
- Learn the [config format, env variables and flags][configuration.md].
76-
- Find [language bindings and tools][libraries-and-tools.md].
77-
- Learn about the dashboard, lock and leader election [modules][modules.md].
78-
- Use TLS to [secure an etcd cluster][security.md].
79-
- [Tune etcd][tuning.md].
80-
81-
[api.md]: https://github.com/coreos/etcd/blob/master/Documentation/api.md
82-
[clustering.md]: https://github.com/coreos/etcd/blob/master/Documentation/clustering.md
83-
[configuration.md]: https://github.com/coreos/etcd/blob/master/Documentation/configuration.md
84-
[libraries-and-tools.md]: https://github.com/coreos/etcd/blob/master/Documentation/libraries-and-tools.md
85-
[modules.md]: https://github.com/coreos/etcd/blob/master/Documentation/modules.md
86-
[security.md]: https://github.com/coreos/etcd/blob/master/Documentation/security.md
87-
[tuning.md]: https://github.com/coreos/etcd/blob/master/Documentation/tuning.md
75+
- Explore the full [API][api].
76+
- Set up a [multi-machine cluster][clustering].
77+
- Learn the [config format, env variables and flags][configuration].
78+
- Find [language bindings and tools][libraries-and-tools].
79+
- Learn about the dashboard, lock and leader election [modules][modules].
80+
- Use TLS to [secure an etcd cluster][security].
81+
- [Tune etcd][tuning].
82+
83+
[api]: https://github.com/coreos/etcd/blob/master/Documentation/api.md
84+
[clustering]: https://github.com/coreos/etcd/blob/master/Documentation/clustering.md
85+
[configuration]: https://github.com/coreos/etcd/blob/master/Documentation/configuration.md
86+
[libraries-and-tools]: https://github.com/coreos/etcd/blob/master/Documentation/libraries-and-tools.md
87+
[modules]: https://github.com/coreos/etcd/blob/master/Documentation/modules.md
88+
[security]: https://github.com/coreos/etcd/blob/master/Documentation/security.md
89+
[tuning]: https://github.com/coreos/etcd/blob/master/Documentation/tuning.md
8890

8991
## Contact
9092

91-
- Mailing list: http://coreos.com/lists/etcd-dev/
92-
- IRC: #coreos on irc.freenode.net
93-
- Planning/Roadmap: https://trello.com/b/OiEbU547/etcd
94-
- Bugs: https://github.com/coreos/etcd/issues
93+
- Mailing list: [etcd-dev](http://coreos.com/lists/etcd-dev/)
94+
- IRC: #[coreos](irc://irc.freenode.org:6667/#coreos) oon freenode.org
95+
- Planning/Roadmap: [milestones](https://github.com/coreos/etcd/issues/milestones)
96+
- Bugs: [issues](https://github.com/coreos/etcd/issues)
9597

9698
## Contributing
9799

98-
See [CONTRIBUTING](https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md) for details on submitting patches and contacting developers via IRC and mailing lists.
100+
See [CONTRIBUTING](CONTRIBUTING.md) for details on submitting patches and the contribution workflow.
99101

100102
## Project Details
101103

102104
### Versioning
103105

104106
#### Service Versioning
105107

106-
etcd uses [semantic versioning][semver].
108+
etcd uses [semantic versioning](http://semver.org)
107109
New minor versions may add additional features to the API.
108110

109111
You can get the version of etcd by issuing a request to /version:
@@ -112,8 +114,6 @@ You can get the version of etcd by issuing a request to /version:
112114
curl -L http://127.0.0.1:4001/version
113115
```
114116

115-
[semver]: http://semver.org/
116-
117117
#### API Versioning
118118

119119
Clients are encouraged to use the `v2` API. The `v1` API will not change.
@@ -124,6 +124,4 @@ During the pre-v1.0.0 series of releases we may break the API as we fix bugs and
124124

125125
### License
126126

127-
etcd is under the Apache 2.0 license. See the [LICENSE][license] file for details.
128-
129-
[license]: https://github.com/coreos/etcd/blob/master/LICENSE
127+
etcd is under the Apache 2.0 license. See the [LICENSE](LICENSE) file for details.

0 commit comments

Comments
 (0)