You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14-19
Original file line number
Diff line number
Diff line change
@@ -1,17 +1,13 @@
1
1
# How to contribute
2
2
3
-
etcd is open source, Apache 2.0 licensed and accepts contributions via Github pull requests.
4
-
This document outlines some of the conventions on commit message formatting, contact points for developers and other resources to make getting your contribution into etcd easier.
3
+
etcd is Apache 2.0 licensed and accepts contributions via Github pull requests. This document outlines some of the conventions on commit message formatting, contact points for developers and other resources to make getting your contribution into etcd easier.
5
4
6
5
# Email and chat
7
6
8
-
For simplicity etcd discussions happen on coreos-dev and in #coreos-dev.
9
-
As the community grows we will move to a dedicated mailing list and IRC channel.
- IRC: #[coreos](irc://irc.freenode.org:6667/#coreos) IRC channel on freenode.org
13
9
14
-
## Getting Started
10
+
## Getting started
15
11
16
12
- Fork the repository on GitHub
17
13
- Read the README.md for build instructions
@@ -22,11 +18,11 @@ This is a rough outline of what a contributor's workflow looks like:
22
18
23
19
- Create a topic branch from where you want to base your work. This is usually master.
24
20
- Make commits of logical units.
25
-
- Make sure your commit messages are in the proper format, see below
21
+
- Make sure your commit messages are in the proper format (see below).
26
22
- Push your changes to a topic branch in your fork of the repository.
27
-
- Submit a pull request to coreos/etcd
23
+
- Submit a pull request to coreos/etcd.
28
24
29
-
Thanks for you contributions!
25
+
Thanks for your contributions!
30
26
31
27
### Code style
32
28
@@ -36,8 +32,7 @@ Please follow this style to make etcd easy to review, maintain and develop.
36
32
37
33
### Format of the commit message
38
34
39
-
etcd follow a rough convention for commit messages borrowed from Angularjs.
40
-
This is an example of a commit:
35
+
etcd follows a rough convention for commit messages borrowed from Angularjs. This is an example of a commit:
41
36
42
37
```
43
38
feat(scripts/test-cluster): add a cluster test command
@@ -46,7 +41,7 @@ This is an example of a commit:
46
41
start for debugging.
47
42
```
48
43
49
-
To make it more formal it looks something like this:
44
+
The format can be more formally described as follows:
50
45
51
46
```
52
47
<type>(<scope>): <subject>
@@ -56,14 +51,14 @@ To make it more formal it looks something like this:
56
51
<footer>
57
52
```
58
53
59
-
The first line is the subject and should not be longer than 70 characters, the second line is always blank and other lines should be wrapped at 80 characters.
60
-
This allows the message to be easier to read on github as well as in various git tools.
54
+
The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters. This allows the message to be easier to read on github as well as
55
+
in various git tools.
61
56
62
57
### Subject line
63
58
64
-
The subject line contains succinct description of the change.
59
+
The subject line contains a succinct description of the change.
65
60
66
-
### Allowed <type>
61
+
### Allowed <type>s
67
62
- feat (feature)
68
63
- fix (bug fix)
69
64
- docs (documentation)
@@ -72,9 +67,9 @@ The subject line contains succinct description of the change.
72
67
- test (when adding missing tests)
73
68
- chore (maintain)
74
69
75
-
### Allowed <scope>
70
+
### Allowed <scope>s
76
71
77
-
Scopes could be anything specifying place of the commit change. For examplestore, api, etc.
72
+
Scopes can be anything specifying the place of the commit change within the repository. For example, "store", "API", etc.
This will bring up etcd listening on port 4001 for client communication and on port 7001 for server-to-server communication.
61
63
62
-
Next lets set a single key and then retrieve it:
64
+
Next, let's set a single key, and then retrieve it:
63
65
64
66
```
65
67
curl -L http://127.0.0.1:4001/v2/keys/mykey -XPUT -d value="this is awesome"
66
68
curl -L http://127.0.0.1:4001/v2/keys/mykey
67
69
```
68
70
69
-
You have successfully started an etcd on a single machine and written a key to the store. Now it time to dig into the full etcd API and other guides.
71
+
You have successfully started an etcd on a single machine and written a key to the store. Now it's time to dig into the full etcd API and other guides.
70
72
71
73
### Next Steps
72
74
73
-
- Explore the full [API][api.md].
74
-
-Setup a [multi-machine cluster][clustering.md].
75
-
- Learn the [config format, env variables and flags][configuration.md].
76
-
- Find [language bindings and tools][libraries-and-tools.md].
77
-
- Learn about the dashboard, lock and leader election [modules][modules.md].
78
-
- Use TLS to [secure an etcd cluster][security.md].
See [CONTRIBUTING](https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md) for details on submitting patches and contacting developers via IRC and mailing lists.
100
+
See [CONTRIBUTING](CONTRIBUTING.md) for details on submitting patches and the contribution workflow.
0 commit comments