Skip to content

ProcessStandardSuite tests #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ProcessStandardSuite tests #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7772dd
structure refactoring
rashtao Feb 25, 2025
dfc97eb
tests refactoring
rashtao Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ An implementation of the [Apache TinkerPop OLTP Provider](https://tinkerpop.apac
## Compatibility

This Provider supports:
* Apache TinkerPop 3.3
* Apache TinkerPop 3.7
* ArangoDB 3.11+ (via ArangoDB Java Driver 7.17.0).

## ArangoDB
Expand Down Expand Up @@ -101,21 +101,24 @@ graph.close();
## A note on element IDs

The provider implementation supports user supplied IDs, i.e. provide an id property for graph
elements, but currently we only support String ids, that is:
elements, but we only support String ids, that is:

```
Vertex v1 = g.addV("person").property(T.id, "1");
```


will create a vertex with id "1". However, implementation wise, in ArangoDB we are only allowed to manipulate the documents `name`, not its `id`. For this reason, providing a TinkerPop vertex id (`T.id`) actually sets the vertex's ArangoDB `name`. As a result, retrieving the vertex by the given id will fail:
will create a vertex with id "1". However, implementation wise, in ArangoDB we are only allowed to manipulate the
documents `name`, not its `id`. For this reason, providing a TinkerPop vertex id (`T.id`) actually sets the vertex's
ArangoDB `name`. As a result, retrieving the vertex by the given id will fail:

```
Vertex v2 = g.V("1");
assert v2 == null;
```

Since we know that documents IDs are created by concatenating (with a slash) the document's collection and its name, then we can find the vertex like so:
Since we know that documents IDs are created by concatenating (with a slash) the document's collection and its name,
then we can find the vertex like so:

```
Vertex v2 = g.V("person/1");
Expand Down
237 changes: 0 additions & 237 deletions jautodoc_templates.xml
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/main/java/com/arangodb/tinkerpop/gremlin/client/ArangoDBBaseDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
import com.arangodb.tinkerpop.gremlin.structure.ArangoDBGraph;
import com.arangodb.shaded.fasterxml.jackson.annotation.JsonIgnore;
import com.arangodb.shaded.fasterxml.jackson.annotation.JsonProperty;
import com.arangodb.tinkerpop.gremlin.structure.ArangoDBVertexPropertyData;

import java.util.List;
import java.util.Map;

/**
* The ArangoDB BaseBaseDocument provides the internal fields required for the driver to correctly
Expand Down Expand Up @@ -48,9 +44,6 @@ public abstract class ArangoDBBaseDocument {
@JsonProperty
protected String label;

@JsonProperty
protected Map<String, List<ArangoDBVertexPropertyData>> properties;

/** The collection in which the element is placed. */

@JsonIgnore
Expand Down
Loading