Add features that allow restriction of the number of wpcom plugins per plan to wpsh #43108

dzver · 2025-04-16T14:47:38Z

This change is not fine to be merged without @claudiucelfilip's work on conditionally enabling plugins on a couple of other plans. It will work but is not easily testable.

Proposed changes:

Provides two new features that will restrict the number of non-default plugins to 1 or 3

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

This is a WPCOMSH change for WPCOM atomic sites. It's only meant to be tested from wp-admin, the Calypso part will come separately.

Using a Business plan dev blog on WPCOM
Modify wpcom-features - PLUGINS_ALLOW_ONE or THREE to include self::WPCOM_BUSINESS_PLANS
Install 1 or 3 plugins

Removing the plugin_action_links will allow you to attempt activating plugins beyond the limit. This should also not work, although without an error as I couldn't find a hook that would handle wp_error properly

It won't allow enabling plugins without returning an error

github-actions · 2025-04-16T14:48:29Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/add-plugins-one-and-three-features branch.

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-04-16T14:48:38Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-04-16T14:51:57Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/wpcomsh/feature-plugins/hooks.php	24/166 (14.46%)	-2.44%	24 💔
projects/plugins/wpcomsh/functions.php	9/157 (5.73%)	-0.84%	20 💔
projects/plugins/wpcomsh/constants.php	0/31 (0.00%)	0.00%	14 💔

Full summary · PHP report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

dzver · 2025-04-16T15:07:27Z

projects/plugins/wpcomsh/constants.php

@@ -33,3 +33,18 @@

 // Date for lowering storage from 200 GB to 50 GB for business and higher plans. Ref: D108151-code.
 define( 'LEGACY_200GB_CUTOFF_DATE', '2023-07-20' );
+
+define(


I'm not sure this is the right way, I'll look into it tomorrow and see if I can come up with another way for identifying the default plugins.

I couldn't find a better way, maybe one will surface during code review. There's a list of woa-specific jetpack plugins that have their activation/deactivation altered but it doesn't include things like the ones here. I'm leaving it as is.

dzver · 2025-04-16T16:39:26Z

projects/plugins/wpcomsh/feature-plugins/hooks.php

+		return $new_value;
+	}
+
+	// Plugins are manually activated one by one


I'll need to see how plugins are activated during provisioning to make sure this code doesn't interfere.

dzver added 4 commits April 15, 2025 16:20

Add two new wpcom features

a4cf71b

Enforce the plugin limit gracefully

65cde74

It won't allow enabling plugins without returning an error

Hide activation link from wp-admin if plugin limit reached

7e6b7df

changelog

bd24fc0

github-actions bot added the [Plugin] Wpcomsh label Apr 16, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 16, 2025

dzver commented Apr 16, 2025

View reviewed changes

Also make it work if we set more than one plugin at a time

7b63204

dzver added [Status] In Progress [Type] Task and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add features that allow restriction of the number of wpcom plugins per plan to wpsh #43108

Add features that allow restriction of the number of wpcom plugins per plan to wpsh #43108

dzver commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

jp-launch-control bot commented Apr 16, 2025 •

edited

Loading

dzver Apr 16, 2025

dzver Apr 17, 2025

dzver Apr 16, 2025

Add features that allow restriction of the number of wpcom plugins per plan to wpsh #43108

Are you sure you want to change the base?

Add features that allow restriction of the number of wpcom plugins per plan to wpsh #43108

Conversation

dzver commented Apr 16, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Apr 16, 2025 • edited Loading

github-actions bot commented Apr 16, 2025 • edited Loading

jp-launch-control bot commented Apr 16, 2025 • edited Loading

Code Coverage Summary

dzver Apr 16, 2025

Choose a reason for hiding this comment

dzver Apr 17, 2025

Choose a reason for hiding this comment

dzver Apr 16, 2025

Choose a reason for hiding this comment

dzver commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

jp-launch-control bot commented Apr 16, 2025 •

edited

Loading