-
Notifications
You must be signed in to change notification settings - Fork 818
CRM: Clean up small bits of unused code #43116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, and zeroBSCRM_getCompanyOrOrgPlural functions
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 4 files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed none of the repositories use any of the removed functions.
While digging into the issue now documented at https://github.com/Automattic/zero-bs-crm/issues/3542#issuecomment-2810534336, I ran across several small bits of code that are no longer used, so this PR cleans them up.
Proposed changes:
This chops the following functions
zbsCustomer_companyDropdown()
ZeroBSCRM::setup_environment()
zeroBSCRM_getContactOrCustomer()
zeroBSCRM_getCompanyOrOrg()
zeroBSCRM_getCompanyOrOrgPlural()
zeroBSCRM_exposePID()
It also does some minor linting and chops some old comments.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Make sure the deleted functions aren't used in the monorepo, the main extensions repo, or the Mail Campaigns repo.