Skip to content

CRM: Clean up small bits of unused code #43116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2025
Merged

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Apr 16, 2025

While digging into the issue now documented at https://github.com/Automattic/zero-bs-crm/issues/3542#issuecomment-2810534336, I ran across several small bits of code that are no longer used, so this PR cleans them up.

Proposed changes:

This chops the following functions

  • zbsCustomer_companyDropdown()
  • ZeroBSCRM::setup_environment()
  • zeroBSCRM_getContactOrCustomer()
  • zeroBSCRM_getCompanyOrOrg()
  • zeroBSCRM_getCompanyOrOrgPlural()
  • zeroBSCRM_exposePID()

It also does some minor linting and chops some old comments.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Make sure the deleted functions aren't used in the monorepo, the main extensions repo, or the Mail Campaigns repo.

@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Apr 16, 2025
@tbradsha tbradsha self-assigned this Apr 16, 2025
@github-actions github-actions bot added [Plugin] CRM Issues about the Jetpack CRM plugin Admin Page React-powered dashboard under the Jetpack menu labels Apr 16, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented Apr 16, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/plugins/crm/includes/jpcrm-language.php 0/14 (0.00%) 0.00% 1 ❤️‍🩹
projects/plugins/crm/includes/ZeroBSCRM.Core.php 0/982 (0.00%) 0.00% -2 💚
projects/plugins/crm/includes/ZeroBSCRM.Forms.php 0/149 (0.00%) 0.00% -2 💚
projects/plugins/crm/includes/ZeroBSCRM.MetaBoxes3.Contacts.php 0/838 (0.00%) 0.00% -9 💚

Full summary · PHP report

coder-karen
coder-karen previously approved these changes Apr 18, 2025
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed none of the repositories use any of the removed functions.

@tbradsha tbradsha merged commit 3a77eac into trunk Apr 21, 2025
63 checks passed
@tbradsha tbradsha deleted the fix/crm/various_cleanups branch April 21, 2025 19:54
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] CRM Issues about the Jetpack CRM plugin [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants