Skip to content

Boost dashboard: fix display of upsell in critical CSS modal #43153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 18, 2025

Fixes HOG-75 -- Dashboard: display issues in upsell in Critical CSS modal

Proposed changes:

The text within the upsell is displayed on a single line:

Before

Screenshot 2025-04-18 at 19 59 48

After

Screenshot 2025-04-18 at 19 59 57

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a site running Boost free
  • Go to Jetpack > Boost
  • Click on the "info" icon after You should regenerate your Critical CSS whenever you make changes to the HTML or CSS structure of your site.
  • Ensure the upsell at the bottom of the modal is displayed properly (see screenshot above).

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Plugin] Boost A feature to speed up the site and improve performance. labels Apr 18, 2025
@jeherve jeherve requested a review from a team April 18, 2025 18:05
@jeherve jeherve self-assigned this Apr 18, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: April 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just discovered that the CTA doesn't do anything on click. I'll log it in a separate issue.

@jeherve jeherve merged commit 50fc23a into trunk Apr 21, 2025
71 of 72 checks passed
@jeherve jeherve deleted the update/boost-admin-upsell-modal-multiline branch April 21, 2025 13:48
@github-actions github-actions bot added this to the boost/3.14.0 milestone Apr 21, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Boost A feature to speed up the site and improve performance. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants