Skip to content

Stable version: Replace v7.6_preview.2 and v7.6-preview.2 with 7.6 #34881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Stable version: Replace v7.6_preview.2 and v7.6-preview.2 with 7.6 #34881

wants to merge 8 commits into from
+13,919 −247

Conversation

mariammuchai
Copy link

… .tsp files

Stable version: Replace v7.6_preview.2 and v7.6-preview.2 with 7.6 in .tsp files

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 22, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 22, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault labels May 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec KeyVault
Swagger Microsoft.KeyVault
JavaScript @azure/keyvault-admin
JavaScript @azure/keyvault-certificates
JavaScript @azure/keyvault-keys
JavaScript @azure/keyvault-secrets

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label May 22, 2025
@vasanthrajams
Copy link
Contributor

@mariammuchai Could you please check if the readme.md file needs to add Tag with 7.6 stable version ?

https://github.com/Azure/azure-rest-api-specs/blob/7ebe3675aa8d48984ede090b0a8b0189f86290ed/specification/keyvault/data-plane/readme.md

vcolin7
vcolin7 approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chlowell
chlowell reviewed May 23, 2025
View reviewed changes
specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.6-preview.2/backuprestore.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 7.6-preview.2 swagger specs should stay the same. The correct version in them is still 7.6-preview.2

@vickm vickm added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell left review comments

@vcolin7 vcolin7 vcolin7 approved these changes

@chen-karen chen-karen chen-karen approved these changes

@vickm vickm Awaiting requested review from vickm vickm is a code owner

@cheathamb36 cheathamb36 Awaiting requested review from cheathamb36 cheathamb36 is a code owner

@heaths heaths Awaiting requested review from heaths heaths is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. data-plane KeyVault new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mariammuchai @vasanthrajams @vcolin7 @chlowell @chen-karen @vickm @AzureRestAPISpecReview