FILT: Read Zeiss TXM/TXRM xCT files

[imikejackson]

Unit Test: We need to find or acquire a small txm file for testing. This is holding this filter back from being included in SIMPLNXCore plugin.

[imikejackson]

@nyoungbq The code is still in a bit of rough shape but the basics are there. I need a unit test and better docs. Since the files are so large not sure where I can come up with a small sample file.

[nyoungbq]

I am approving it since I didn't see any obvious bugs, and this repo is more lax in requirements since it's a staging ground.

For future changes: I poured over it, there were a couple of things that stood out, such as making a temporary datastructure/image geom to calculate the origin (should just be done with a util function or inlined calculations), commented out code, and logic paths that do nothing.

[imikejackson]

@nyoungbq Thanks for the feedback.

[imikejackson]

@nyoungbq I'm not going to change anyting in the "oless" folder since that actually came from another GitHub repo.

[imikejackson]

@nyoungbq Removed the temp DataStructure. Calculated the feedback strings inline. Fixed other bugs related to the slice start and stop values.

[nyoungbq]

@imikejackson looked it over the files that changed and it all looks good, the two offered changes are little and just give the compiler more chances to optimize

[imikejackson]

@nyoungbq Used a swtich statement instead to make it clear we are only using values from the enumeration.

[nyoungbq]

@nyoungbq Used a swtich statement instead to make it clear we are only using values from the enumeration.

That works, chances are it will be translated to the same thing either way. Comparison is faster for small cases but most of the time the llvm will optimize accordingly under the covers. Here's an overflow post if you are interested: https://stackoverflow.com/a/60110730

[nyoungbq]

Good to merge