Skip to content

[project][ENG-7225] share cleanup 2025 (milestone 1: simplify) #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 23, 2025

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Apr 23, 2025

consists of:

(note: subset of #850 that can be released sooner)

summary of changes

  • add management commands
    • shtrove_indexer_run (replaces sharectl search daemon)
    • shtrove_search_setup (replaces sharectl search setup)
    • shtrove_search_teardown (replaces sharectl search purge)
    • delete_pretrove_data (for letting go of some past)
  • delete (some) sharev2 api
    • /api/v2/formattedmetadatarecords/...
    • /api/v2/normalizeddata/...
      • note: sharev2 “push” is a POST to this endpoint -- replaced by /trove/ingest
    • /api/v2/sourceregistrations/...
    • /api/v2/schemas/...
    • /api/v1/share/data
  • delete sharev2 ingestion pipeline
    • share/harvest/*
    • share/harvesters/*
    • share/metadata_formats/*
    • share/regulate/*
    • share/schema/*
    • share/sources/*
    • share/tasks/*
      • except schedule_index_backfill -- moved to share.models.index_backfill for now
    • share/transform/*
    • share/transformers/*
    • anything deactivated by the ignore_sharev2_ingest feature flag
  • delete (some) sharev2 db models/tables from share/models/...
    • core.py: NormalizedData, FormattedMetadataRecord
    • jobs.py: HarvestJob
    • registration.py: ProviderRegistration
    • sources.py: SourceStat
  • remove special ember-share handling (for local dev)
  • remove all dead code and requirements easily removed

@aaxelb aaxelb changed the title [project] share cleanup 2025 (milestone 1: simplify) [project][ENG-7225] share cleanup 2025 (milestone 1: simplify) Apr 23, 2025
@aaxelb aaxelb marked this pull request as ready for review April 23, 2025 17:40
@aaxelb aaxelb merged commit 61884b9 into develop Apr 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants