Skip to content

[ENG-7729] | migrated WaterButler to Poetry for dependency management #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/buff-worms-wb
Choose a base branch
from

Conversation

sh-andriy
Copy link
Contributor

@sh-andriy sh-andriy commented Apr 21, 2025

Purpose

Migrate WaterButler to Poetry for dependency management

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

ENG-7729

Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to get rid of the wb_requirements container entirely. It lets us rebuild dependency changes while developing waterbutler. I'm not sure if we still need the local_bin volume though. We might need newrelic binaries to run WB with NR monitoring.

@sh-andriy sh-andriy requested a review from felliott April 25, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants