Skip to content

[ENG-7810] improve action requests creation #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/pbs-25-08
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Apr 24, 2025

Purpose

Fix's a 502 that happened when the permission's class hit a NoneType target id

Changes

  • improves tests
  • adds validation for target ids

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-7810

@Johnetordoff Johnetordoff force-pushed the fix-moderator-permission-actions branch from 29db28b to 56de5df Compare April 25, 2025 13:11
@Johnetordoff Johnetordoff force-pushed the fix-moderator-permission-actions branch from 56de5df to 2e8421a Compare April 25, 2025 13:42
@Johnetordoff Johnetordoff changed the title [WIP][ENG-7810] improve action requests creation [ENG-7810] improve action requests creation Apr 25, 2025
@brianjgeiger brianjgeiger marked this pull request as ready for review April 28, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants