-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix #8131 #8231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mc1.20.1/dev
Are you sure you want to change the base?
Fix #8131 #8231
Conversation
Hi, it'd make review easier (and often quicker) if unrelated fixes/features are submitted as separate PRs, that way they can get looked at in isolation where the review of one does not prevent the other from getting merged (: |
Oh but I didn't know how to separate PRs. I googled and got to know that one branch could have only one PR |
If you make additional branches branching off from the base branch, each of those can have a separate PR. |
This PR still contains all three commits despite the new PRs and the force push since then. |
extractItems isn't guaranteed to show actual amount of items
Updated |
https://maven.saps.dev/releases returns 404