Skip to content

Fix #8131 #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mc1.20.1/dev
Choose a base branch
from
Open

Conversation

aleck099
Copy link

@aleck099
Copy link
Author

Add overwrite option to schematicAndQuill gui
Screenshot_20250410_171449
Screenshot_20250410_171455

@aleck099 aleck099 changed the title Update: Dependency link of ftb mods Add overwrite option to schematicAndQuill gui Apr 10, 2025
@VoidLeech
Copy link
Collaborator

Hi, it'd make review easier (and often quicker) if unrelated fixes/features are submitted as separate PRs, that way they can get looked at in isolation where the review of one does not prevent the other from getting merged (:
Since atm this is a critical fix, a feature, and a non-critical fix all together.

@aleck099
Copy link
Author

Hi, it'd make review easier (and often quicker) if unrelated fixes/features are submitted as separate PRs, that way they can get looked at in isolation where the review of one does not prevent the other from getting merged (: Since atm this is a critical fix, a feature, and a non-critical fix all together.

Oh but I didn't know how to separate PRs. I googled and got to know that one branch could have only one PR

@VoidLeech
Copy link
Collaborator

If you make additional branches branching off from the base branch, each of those can have a separate PR.

@aleck099 aleck099 changed the title Add overwrite option to schematicAndQuill gui Fix #8131 Apr 10, 2025
@VoidLeech
Copy link
Collaborator

This PR still contains all three commits despite the new PRs and the force push since then.

extractItems isn't guaranteed to show actual amount of items
@aleck099
Copy link
Author

This PR still contains all three commits despite the new PRs and the force push since then.

Updated

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants