Skip to content

Feature/add indexer #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -46,6 +46,12 @@ static Utf16ValueStringBuilder()

/// <summary>Length of written buffer.</summary>
public int Length => index;

/// <summary>Gets a <see cref="char"/> stored under <paramref name="index"/> </summary>
[IndexerName("Chars")]
// ReSharper disable once ParameterHidesMember - follow naming from StringBuilder to ease migration.
public char this[int index] => buffer![index];

/// <summary>Get the written buffer data.</summary>
public ReadOnlySpan<char> AsSpan() => buffer.AsSpan(0, index);
/// <summary>Get the written buffer data.</summary>
6 changes: 6 additions & 0 deletions src/ZString/Utf16ValueStringBuilder.cs
Original file line number Diff line number Diff line change
@@ -46,6 +46,12 @@ static Utf16ValueStringBuilder()

/// <summary>Length of written buffer.</summary>
public int Length => index;

/// <summary>Gets a <see cref="char"/> stored under <paramref name="index"/> </summary>
[IndexerName("Chars")]
// ReSharper disable once ParameterHidesMember - follow naming from StringBuilder to ease migration.
public char this[int index] => buffer![index];

/// <summary>Get the written buffer data.</summary>
public ReadOnlySpan<char> AsSpan() => buffer.AsSpan(0, index);
/// <summary>Get the written buffer data.</summary>
103 changes: 102 additions & 1 deletion tests/ZString.Tests/StringBuilderTest.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System;
using Cysharp.Text;
using FluentAssertions;
using System.Text;
using Xunit;

namespace ZStringTests
@@ -22,5 +22,106 @@ public void Utf8DisposeTest()
sb.Dispose();
sb.Dispose(); // call more than once
}

[Theory]
[InlineData("cucu", "mber")]
[InlineData("Choco", "pie")]
public void Append_WhenCalled_IsCorrect(string a, string b)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(a);
sut.Append(b);

var result = sut.ToString();
result.Should().Be($"{a}{b}");
}

[Theory]
[InlineData("cucu", "mber")]
[InlineData("Choco", "pie")]
public void Append_WhenChars_IsCorrect(string species, string b)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(species);
var chars = new ReadOnlySpan<char>(b.ToCharArray());
sut.Append(chars);

var result = sut.ToString();
result.Should().Be($"{species}{b}");
}

[Theory, InlineData("choco", "apple", "pie")]
public void Replace_WhenCalled_IsCorrect(string species, string alternative, string mainPart)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(species);
sut.Append(mainPart);
sut.Replace(species, alternative);

var result = sut.ToString();
result.Should().Be($"{alternative}{mainPart}");
}

[Theory, InlineData("choco", "apple", "pie")]
public void Insert_WhenCalled_IsCorrect(string species, string alternative, string mainPart)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(species);
sut.Append(mainPart);
sut.Insert(species.Length, alternative);

var result = sut.ToString();
result.Should().Be($"{species}{alternative}{mainPart}");
}

[Theory]
[InlineData("cat")]
[InlineData("dog")]
public void IndexerAlike_WhenCalled_IsCorrect(string body)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(body);

var letter = sut.AsSpan()[1];
letter.Should().Be(body[1]);
}

[Theory]
[InlineData("cat")]
[InlineData("dog")]
public void IndexerAlike_WhenCalledOnLast_IsCorrect(string body)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(body);

var index = body.Length - 1;
var letter = sut.AsSpan()[index];
letter.Should().Be(body[index]);
}

[Theory]
[InlineData("cat")]
[InlineData("dog")]
public void Indexer_WhenCalled_IsCorrect(string body)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(body);

var letter = sut[1];
letter.Should().Be(body[1]);
}

[Theory]
[InlineData("cat")]
[InlineData("dog")]
public void Indexer_WhenCalledOnLast_IsCorrect(string body)
{
using var sut = ZString.CreateStringBuilder();
sut.Append(body);

var index = body.Length - 1;
var letter = sut[index];
letter.Should().Be(body[index]);
}
}
}