-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate the session replay mobile setup instructions to Cdocs #29079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jhgilbert
wants to merge
21
commits into
master
Choose a base branch
from
jen.gilbert/cdocs-pilot-mobile-sr-setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
…ilot-mobile-sr-setup' into jen.gilbert/cdocs-pilot-mobile-sr-setup
…ilot-mobile-sr-setup' into jen.gilbert/cdocs-pilot-mobile-sr-setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This converts the RUM Session Replay setup instructions to Markdoc. These instructions are used in two places, so I put the instructions in a partial.
Note for the websites team
The new version of the Cdocs-Hugo integration version only has a small change (PR), which corrects the expected partials folder from
layouts/partials
tolayouts/shortcodes
to better align with writers' expectations.Reviewer instructions
There is no new content in this PR, just the setup of content filters and replacing Hugo shortcodes with Markdoc tags (like replacing tabs with if tags).
I have QA'd these pages using the relevant items from the Cdocs QA list. I'm mainly just looking for a sanity check that nothing looks odd.
The only two features that haven't been QA'd in prod before are:
Otherwise, the purpose behind these additional pages is just to drive more traffic to Cdocs so we can gather data. We aren't really intending to test anything new here.
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes