Skip to content

Changed sankeys content to pathways #29229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iadjivon
Copy link
Contributor

@iadjivon iadjivon commented May 7, 2025

What does this PR do? What is the motivation?

The PANA UI no longer mentions Sankeys. It has been changed to Pathways. Changing the Docs to reflect this.

Merge instructions

Merge readiness:

  • Ready for merge

@iadjivon iadjivon requested a review from a team as a code owner May 7, 2025 21:54
@github-actions github-actions bot added the Images Images are added/removed with this PR label May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

Preview links (active after the build_preview check completes)

Modified Files

@buraizu buraizu self-assigned this May 7, 2025
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just left one suggestion and a question


{{< img src="product_analytics/segmentation/segmentation-4.png" alt="Show a list of users in the Premium users segment who were active in the last month, organized by the number of sessions they had.">}}
{{< img src="product_analytics/segmentation/analytics-explorer.png" alt="Show a list of users in the Premium users segment who were active in the last month, organized by the number of sessions they had.">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< img src="product_analytics/segmentation/analytics-explorer.png" alt="Show a list of users in the Premium users segment who were active in the last month, organized by the number of sessions they had.">}}
{{< img src="product_analytics/segmentation/analytics-explorer.png" alt="Show a list of users in the Premium Shopist Customers segment who were active in the last month, organized by the number of sessions they had.">}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the new graph is organized by the number of All events rather than all sessions as in the previous screenshot. Should this be updated to say "organized by the total number of events"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question, I'm looking into this All events vs all sessions and will follow-up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants