Skip to content

Cdocs pilot page #2 (Proxy RUM browser data) #29246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jhgilbert
Copy link
Contributor

@jhgilbert jhgilbert commented May 8, 2025

What does this PR do? What is the motivation?

This adds the second Cdocs pilot page to the docs site, and bumps the Cdocs integration to the latest version. I'm adding these in the same PR because the pilot page demonstrates many of the integration changes that would otherwise be difficult to test.

Notes for Heston

  • This page shows two new (to prod, at least) features:
    • Use of DD site based customization
    • A different TOC for different filter choices (>=5.4.0 vs >=4.34.0)
  • I reworked this content a little more than I normally would, because I wanted to test a few Markdoc things. The original content was SME-submitted and then edited by me, so I don't think anyone would object.
  • I reorganized the customization_config directory to keep any version-specific stuff out of the way. I imagine those could add a lot of clutter otherwise.
  • I've QA'd the new docs page according to the Cdocs QA checklist. Let me know if I should add anything to that list.

Notes for the websites team

  • I've QA'd the integration changes according to the Cdocs QA checklist. Let me know if I should add anything to that list.
  • I added a changelog to the Cdocs integration to make it easy to review any relevant releases, please refer to that for more details on the differences between the current version on the docs site and the target version.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@jhgilbert jhgilbert added the WORK IN PROGRESS No review needed, it's a wip ;) label May 8, 2025
@github-actions github-actions bot added the Guide Content impacting a guide label May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

@jhgilbert jhgilbert added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) labels May 8, 2025
@jhgilbert jhgilbert marked this pull request as ready for review May 8, 2025 22:53
@jhgilbert jhgilbert requested review from a team as code owners May 8, 2025 22:53
default: true
- id: socks

rum_browser_sdk_source_options:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one to the end of the file are the new option groups, the other two just got reorganized.

@@ -0,0 +1,35 @@
traits:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file just got renamed, it actually only has one change, flagged below.

label: "OS"
internal_notes: Mobile operating system, such as Android.

- id: lib_src
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change is that I renamed this from pkg_mgr to allow for a broader range of logical values.

@@ -0,0 +1,5 @@
traits:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file is new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant