Skip to content

chore: Potential fix for code scanning alert no. 2: Workflow does not contain permissions #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

JamieSinn
Copy link
Member

Potential fix for https://github.com/DevCycleHQ/java-server-sdk/security/code-scanning/2

To fix the issue, we will add a permissions block to the workflow. Based on the provided code, the workflow primarily interacts with repository contents (e.g., fetching the pull request SHA). Therefore, the minimal required permission is likely contents: read. If additional permissions are required for the third-party action, they can be added explicitly.

The permissions block will be added at the job level (harness-tests) to scope it specifically to this job.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

@JamieSinn JamieSinn changed the title Potential fix for code scanning alert no. 2: Workflow does not contain permissions chore: Potential fix for code scanning alert no. 2: Workflow does not contain permissions May 15, 2025
@JamieSinn JamieSinn marked this pull request as ready for review May 15, 2025 17:24
@JamieSinn JamieSinn requested a review from a team May 15, 2025 17:24
@JamieSinn JamieSinn enabled auto-merge (squash) May 15, 2025 17:24
JamieSinn and others added 2 commits May 15, 2025 13:30
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Norris <jonathan@taplytics.com>
@JamieSinn JamieSinn disabled auto-merge May 20, 2025 14:00
@JamieSinn JamieSinn merged commit 56ff2bc into main May 20, 2025
6 of 7 checks passed
@JamieSinn JamieSinn deleted the alert-autofix-2 branch May 20, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants