Skip to content

add BinaryApp app type #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 26, 2025
Merged

add BinaryApp app type #26

merged 22 commits into from
Apr 26, 2025

Conversation

gilesknap
Copy link
Contributor

Adds a new type of app which downloads a standalone binary, checks its hash and places it in the entrypoints folder.

Also adds the argocd module to demo_configuration in order to demonstrate the feature.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (32ef01f) to head (464f20f).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
src/deploy_tools/app_builder.py 77.41% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   42.55%   75.63%   +33.07%     
===========================================
  Files          23       24        +1     
  Lines         860      911       +51     
===========================================
+ Hits          366      689      +323     
+ Misses        494      222      -272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilesknap gilesknap mentioned this pull request Apr 26, 2025
@gilesknap
Copy link
Contributor Author

@MJGaughran you may have noticed that I got all twisted up trying to rebase and merge these 3 PRs. Please just look away!

@gilesknap gilesknap merged commit fd50e1c into main Apr 26, 2025
17 checks passed
@gilesknap gilesknap deleted the binary-app branch April 26, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants