Skip to content

Enabled having a different group identifier that is not the app identifier #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enabled having a different group identifier that is not the app identifier #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions IOS_INSTRUCTIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Create an App Group to be able to share data between your extension and your app

![Add App Groups](screenshots/Xcode-05.png)

At the bottom of the window on Xcode you should see an `App Groups` section. Press the `+` button and add a group named `group.YOUR_APP_BUNDLE_ID`.
At the bottom of the window on Xcode you should see an `App Groups` section. Press the `+` button and add a group named `group.AN_APP_BUNDLE_ID`.

Repeat this process for the Share Extension target, with the exact same group name.

Expand All @@ -101,13 +101,17 @@ Add the following to your app's `Info.plist` (if you already had other URL Schem
</array>
</dict>
</array>
<key>HostAppBundleIdentifier</key>
<string>YOUR_APP_GROUP_IDENTIFIER_WITHOUT_GROUP_AND_POINT</string>
<!-- This is the app group identifier without "group." - E.G. for app group "group.com.myapp" : "com.myapp" -->
```

Add the following to your Share Extension's `Info.plist`:

```OpenStep Property List
<key>HostAppBundleIdentifier</key>
<string>YOUR_APP_TARGET_BUNDLE_ID</string>
<string>YOUR_APP_GROUP_IDENTIFIER_WITHOUT_GROUP_AND_POINT</string>
<!-- This is the app group identifier without "group." - E.G. for app group "group.com.myapp" : "com.myapp" -->
<key>HostAppURLScheme</key>
<string>YOUR_APP_URL_SCHEME_DEFINED_ABOVE</string>
<!-- This url scheme CONTAINS :// at the end - E.G. "mycustomscheme://"-->
Expand Down
4 changes: 2 additions & 2 deletions ios/Modules/ShareMenu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class ShareMenu: RCTEventEmitter {
}

guard let scheme = url.scheme, scheme == targetUrlScheme else { return }
guard let bundleId = Bundle.main.bundleIdentifier else { return }
guard let bundleId = Bundle.main.object(forInfoDictionaryKey: HOST_APP_IDENTIFIER_INFO_PLIST_KEY) else { return }
guard let userDefaults = UserDefaults(suiteName: "group.\(bundleId)") else {
print("Error: \(NO_APP_GROUP_ERROR)")
return
Expand All @@ -102,7 +102,7 @@ class ShareMenu: RCTEventEmitter {
func getSharedText(callback: RCTResponseSenderBlock) {
var data = [DATA_KEY: sharedData] as [String: Any]

if let bundleId = Bundle.main.bundleIdentifier, let userDefaults = UserDefaults(suiteName: "group.\(bundleId)") {
if let bundleId = Bundle.main.object(forInfoDictionaryKey: HOST_APP_IDENTIFIER_INFO_PLIST_KEY), let userDefaults = UserDefaults(suiteName: "group.\(bundleId)") {
data[EXTRA_DATA_KEY] = userDefaults.object(forKey: USER_DEFAULTS_EXTRA_DATA_KEY) as? [String: Any]
} else {
print("Error: \(NO_APP_GROUP_ERROR)")
Expand Down