Skip to content

Video & Iframe support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Video & Iframe support #16

wants to merge 11 commits into from

Conversation

hamsahmedansari
Copy link

@hamsahmedansari hamsahmedansari commented Aug 20, 2019

Feature

  • Now we can add Video & Iframe (for youtube etc).
  • Thumbnail is auto fetching from video stream URL

Code

<FbImageLibrary images={[
  { url: 'imageURL', },
  { url: 'imageURL', thumbnail: 'imageThumbnailURL' },
  { url: 'videoURL', thumbnail: 'videoThumbnailURL',isVideo:true,props:{style:{width:10,height:10}} },
  { url: 'videoURL',isVideo:true },
  { url: 'iframeURL', thumbnail: 'iframeThumbnailURL',iFrame:true,props:{style:{width:10,height:10}} },
  { url: 'iframeURL',iFrame:true },
]}

Video

Label Default Example Status
url null imageURL REQUIRED
isVideo false {true} REQUIRED
thumbnail null imageURL Optional
props {} {style:{videoStyles}} Optional

Iframe

Label Default Example Status
url null imageURL REQUIRED
iFrame false {true} REQUIRED
thumbnail null imageURL Optional
props {} {style:{videoStyles}} Optional

Changelog

  • Dependancy is changed From react-image-lightbox to lightbox-react

[3, 4].includes(images.length) ||
(images.length > +countFrom && [3, 4].includes(+countFrom));
let first = this.renderOverlay(),
second = overlay;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable name should represent the usage

@kashifsulaiman
Copy link
Contributor

@hamsahmedansari Thanks for the PR, I've requested some changes! Hope you'll find them helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants