breaking: rename lulc topic to land-cover and change filter #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -547,7 +547,7 @@ mapaction-rivers-length: | |||
|
|
|||
| ### IDEALVGI PROJECT ### | |||
|
|
|||
| lulc: | |||
| land-cover: | |||
| name: Land Use and Land Cover | |||
| description: >- | |||
| Features related to land use and land cover. | |||
There was a problem hiding this comment.
This description is probably not right anymore. Lets shorten it to the first sentence.
| https://github.com/jasp382/glass/tree/master/core/glass/ete/osm2lulc; | ||
| Schultz et al 2017 https://doi.org/10.1016/j.jag.2017.07.014; | ||
| https://www.geog.uni-heidelberg.de/gis/ideal_en.html | ||
| TODO |
There was a problem hiding this comment.
I would just remove it for now. We might have one in the future though.
| @@ -557,13 +557,9 @@ lulc: | |||
| endpoint: elements | |||
| aggregation_type: area | |||
| filter: >- | |||
| (landuse=allotments or landuse=animal_keeping or landuse=basin or landuse=brownfield or landuse=cemetery or landuse=churchyard or landuse=civic_admin or landuse=commercial or landuse=construction or landuse=depot or landuse=education or landuse=farmland or landuse=farmyard or landuse=forest or landuse=garages or landuse=grass or landuse=greenfield or landuse=greenhouse_horticulture or landuse=harbour or landuse=industrial or landuse=landfill or landuse=logging or landuse=meadow or landuse=military or landuse=orchard or landuse=plant_nursery or landuse=port or landuse=quarry or landuse=railway or landuse=recreation_ground or landuse=religious or landuse=reservoir or landuse=residential or landuse=retail or landuse=salt_pond or landuse=village_green or landuse=vineyard or natural=bare_rock or natural=beach or natural=dune or natural=fell or natural=glacier or natural=grassland or natural=heath or natural=landslide or natural=mud or natural=rock or natural=sand or natural=scree or natural=scrub or natural=shingle or natural=water or natural=wetland or natural=wood or waterway=boatyard or waterway=dam or waterway=dock or waterway=riverbank) and geometry:polygon | |||
| (landuse=* and landuse!=no) or natural=water and geometry:polygon | |||
There was a problem hiding this comment.
I think we need to include more values for natural key such as
"water", "riverbank", "reservoir", "basin", "dock", "canal", "pond"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue
Closes #898
New or changed dependencies
Checklist
main(e.g. throughgit rebase mainif necessary)Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~) and remove their checkboxes.