-
Notifications
You must be signed in to change notification settings - Fork 113
Enhance dataset viewer and saving of layer settings #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue - Restore default dataset style on page change
steps:
- login and upload a dataset
- open the dataset
- edit layer settings and create a new style
- select the new create style (not the default one)
- go back to the dataset
Expected:
- dataset is rendering with the default style
Current:
- dataset is rendering with the selected style
restore_default_style.mp4
Issue - Save the style name on change default style
steps:
- login and upload a dataset
- open the dataset
- edit layer settings and create a new style
- select the new create style (not the default one)
- make the new style the default one (click star button)
Expected:
- a new request is performed to save the style name also in the layer settings. We need to intercept the default style action and send a parallel request to save the style, so a user does not need to click on the save button for this specific case
Current:
- the new default style is not updated in geonode until a user click on the save button. A user could not click the save button leading to an inconsistent state
update_default_style.mp4
@dsuren1 I think we should exclude completely the style property from the data payload so style will be always undefined and GeoServer will pick always the default |
@allyoucanmap Issue 2 - @giohappy This introduces a modification to our earlier discussion (as part of default style and save pending indicator issue):
In either case, style will not be saved to data payload, i.e when layer setting is loaded the default style is always selected |
…viewer * commit '73a073ef6d312baaf10991cc2f4b5f17c5e40b8e': Resource page config based on type (GeoNode#2050) [create-pull-request] automated change (GeoNode#2066) Fix - Actionbar menus are hidden behind the document viewer (GeoNode#2048) [create-pull-request] automated change (GeoNode#2065) Updated MS submodule to latest stable (GeoNode#2051) [create-pull-request] automated change (GeoNode#2064) Enhance close open right panel handler (GeoNode#2059)
To streamline the process of saving layer settings—including style configuration—we propose removing the default style selection button (star icon). Instead, when a user saves the layer settings, we will intercept the selected style and perform a GeoServer API call to set it as the default. After that, the rest of the layer settings will be saved as usual. This approach ensures that GeoNode remains in sync with GeoServer regarding the default style |
@dsuren1 please proceed with this proposed implementation, thanks |
* reset_pending: remove inbox link from the user menu (GeoNode#2067)
Description
This PR address the inconsistency loading dataset information on certain pages and enhances the layer settings save functionality
Screenshot