-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(generative-ai): clear unused samples and update gemini model name #4067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @msampathkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on improving the generative AI samples by clearing unused samples and updating the Gemini model name. Specifically, it removes several JavaScript files related to batch prediction and feature store functionalities, and updates the model name from 'gemini-1.5-flash-002' to 'gemini-2.0-flash-001' in the batch prediction samples.
Highlights
- Sample Cleanup: Removes unused JavaScript files, including 'ai-platform/snippets/batch-code-predict.js', 'ai-platform/snippets/batch-read-feature-values-sample.js', 'ai-platform/snippets/batch-text-predict.js', and others, to reduce clutter and improve maintainability.
- Model Name Update: Updates the Gemini model name from 'gemini-1.5-flash-002' to 'gemini-2.0-flash-001' in 'ai-platform/snippets/batch-prediction/batch-predict-bq.js' and 'ai-platform/snippets/batch-prediction/batch-predict-gcs.js' to reflect the latest model version.
Changelog
Click here to see the changelog
- ai-platform/snippets/batch-code-predict.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/batch-prediction/batch-predict-bq.js
- Updated model name from 'gemini-1.5-flash-002' to 'gemini-2.0-flash-001'.
- ai-platform/snippets/batch-prediction/batch-predict-gcs.js
- Updated model name from 'gemini-1.5-flash-002' to 'gemini-2.0-flash-001'.
- ai-platform/snippets/batch-read-feature-values-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/batch-text-predict.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/cancel-batch-prediction-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/cancel-custom-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/code-model-tuning.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-batch-embedding.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-batch-prediction-job-video-action-recognition.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-dataset.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-featurestore-fixed-nodes-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-hyperparameter-tuning-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/create-training-pipeline-video-action-recognition.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-batch-prediction-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-custom-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-dataset.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-endpoint.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-export-model.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/delete-model.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/deploy-model-custom-trained-model.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-batch-prediction-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-custom-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-entity-type-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-hyperparameter-tuning-job.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-model-evaluation-video-action-recognition.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-model-evaluation.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/get-training-pipeline.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/imagen-edit-image-inpainting-insert-mask.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/imagen-edit-image-inpainting-remove-mask.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/imagen-edit-image-mask-free.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/imagen-edit-image-outpainting-mask.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/import-data-video-action-recognition.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/import-data.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-endpoints.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-entity-types-async-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-entity-types-stream-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-features-async-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-features-stream-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-featurestores-async-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-featurestores-stream-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/list-tuned-models.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/package.json
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-chat-prompt.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-code-chat.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-code-completion-comment.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-code-completion-test-function.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-code-generation-function.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-code-generation-unittest.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-image-classification.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-image-from-text.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-text-embeddings-preview.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-text-extraction.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-text-news-classification.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-text-prompt.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/predict-text-sentiment.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/quickstart.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/search-features-async-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/search-features-stream-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/tuning.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/undeploy-model.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/update-entity-type-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/update-feature-sample.js
- Removed the entire file as it's no longer needed.
- ai-platform/snippets/update-featurestore-fixed-nodes-sample.js
- Removed the entire file as it's no longer needed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A digital spring clean,
Old samples now unseen,
Models evolve fast,
New versions amassed,
Code's garden, fresh and green.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on clearing unused samples and updating the Gemini model name across multiple files. The changes seem straightforward, but it's essential to verify the correctness of the model name update and the impact of removing the samples.
Summary of Findings
- Model Name Update: The pull request updates the Gemini model name from 'gemini-1.5-flash-002' to 'gemini-2.0-flash-001' in several files. It's crucial to verify that this change aligns with the intended model usage and that 'gemini-2.0-flash-001' is the correct and stable model for these samples.
- Sample Removal: The pull request removes several sample files (e.g.,
batch-code-predict.js
,batch-read-feature-values-sample.js
). It's important to ensure that these samples are indeed unused and that their removal doesn't negatively impact the overall functionality or completeness of the documentation.
Merge Readiness
The pull request seems to be on the right track, but there are a few things that need to be verified before merging. I recommend verifying the correctness of the model name update and the impact of removing the samples. I am unable to approve this pull request, and users should have others review and approve this code before merging.
Description
No new samples are added. I have cleared all un-used samples and update the Gemini Model name for the samples that are useful