LAGraph v1.2 #308
LAGraph v1.2 #308
Conversation
cleanup; with and without SuiteSparse; add more LG_SET_* in place of GxB
testing argmin/argmax
test_diameter: check scalar results (exact diameter)
DrTimothyAldenDavis
requested review from
michelp,
mcmillan03,
tgmattso and
swilly22
revise github CI on risc-v: on dispatch only
|
I think this is ready to merge. We can make further revisions before releasing a v1.2 version of course. The tests in experimental/test are mostly complete, but some could use more work. For example, the test_diameter method tests the scalar return values (diameter and estimated diameter) but not the vector results (peripheral, level, parent, and eccentricity). There are likely other tests that should be augmented. But I think having partial tests is OK for methods in the experimental folder. |
| strategy: | ||
| matrix: | ||
| config: | ||
| # FIXME: switch to 10.1.0 when it is released: |
There was a problem hiding this comment.
Before we release a stable v1.2, I will have a GraphBLAS v10.1.0 ready. That version of GraphBLAS has an important feature: the ability to force GraphBLAS.h to not expose any GxB methods to the user application, with
#define GRAPHBLAS_VANILLA
#include <GraphBLAS.h>
That addition to GraphBLAS enabled me to find some GxB's that had snuck into the LAGraph "vanilla" build.
.github/workflows/build.yml
Outdated
| strategy: | ||
| matrix: | ||
| config: | ||
| # if there are multiple items in this list, only use should | ||
| # deployit=true for just one of them. | ||
| - {grb_version: 9.3.1, deployit: true} | ||
| - {grb_version: 9.0.0, deployit: false} | ||
| - {grb_version: 10.0.3, deployit: true} |
There was a problem hiding this comment.
Before we release a stable v1.2, I will have a GraphBLAS v10.1.0 ready. That version of GraphBLAS has an important feature: the ability to force GraphBLAS.h to not expose any GxB methods to the user application, with
#define GRAPHBLAS_VANILLA
#include <GraphBLAS.h>
That addition to GraphBLAS enabled me to find some GxB's that had snuck into the LAGraph "vanilla" build.
build.yml: use latest release of SuiteSparse:GraphBLAS
resolve FIXMEs in src
changes from SuiteSparse pr 952: avoiding VLAs and some gcc OpenMP ex…
bug fix: LAGr_PeerPressureClustering; segfault on 32-bit platforms
No description provided.