Skip to content

Update kernel.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update kernel.py #4

wants to merge 1 commit into from

Conversation

lomanhei
Copy link

@lomanhei lomanhei commented Aug 5, 2022

Support writting SQL with spaces or new lines.

Issue

Using the original version resulted an error: (pymysql.err.ProgrammingError) ... , 'Cancelled', 'Shipped') LIMIT 20 limit 1000], with the code below

   ...
    'Cancelled',
    'Shipped')
LIMIT
    20;

Cause

' limit ' not in l is not smart enough to detect '/n' or '/t' as separator.

...
if l.startswith('select ') and ' limit ' not in l:
...

Fix

Convert any '/n' or '/t' to ' '

...
l = l.replace('\t',' ').replace('\n',' ')
...

Support writting SQL with spaces or new lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant